Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Forbid XVM re-entrancy #986

Closed
shaunxw opened this issue Jul 27, 2023 · 0 comments · Fixed by #998
Closed

Forbid XVM re-entrancy #986

shaunxw opened this issue Jul 27, 2023 · 0 comments · Fixed by #998
Assignees
@shaunxw
Labels
XVM Related to XVM

Comments

@shaunxw
Copy link
Member

shaunxw commented Jul 27, 2023

About re-entrancy, I think both are solved in their respective VMs/crates.

EVM takes care of it here.
WASM takes care of it here.

Perhaps we should also prohibit re-entrancy into XVM itself?

Originally posted by @Dinonard in #980 (comment)
@shaunxw shaunxw self-assigned this Jul 27, 2023
@shaunxw shaunxw added the XVM Related to XVM label Jul 27, 2023
@shaunxw shaunxw mentioned this issue Jul 27, 2023
Merged
5 tasks
@shaunxw shaunxw mentioned this issue Aug 9, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shaunxw shaunxw

Labels
XVM Related to XVM
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

pallet-xvm refactor follow-up AstarNetwork/Astar
1 participant
@shaunxw