Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Bounding ElectionProvider #11242

Closed
wants to merge 11 commits into from
Closed

Bounding ElectionProvider #11242

wants to merge 11 commits into from

Conversation

georgesdib
Copy link
Contributor

@georgesdib georgesdib commented Apr 19, 2022

This replaces #11229

Implements Step 1 of paritytech/polkadot-sdk#461

@kianenigma

Polkadot companion: paritytech/polkadot#5351

Polkadot address: 131dPecTmpTC1p1ofemufqFBJo9vNbV7dkgN7vWwKnaSMkC4

@kianenigma kianenigma added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Apr 20, 2022
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main thing that I see missing is:

We are thinking of actually setting a MaxBackersPerWinner (e.g. 2048) enforcing it. This means that we 100% need that SortIntoBoundedSupports, and most importantly, the miner code (unisgned.rs) should use it.

We might need to play a bit of game here to allow the Miner to configure its behavior. Doing SortIntoBoundedSupports might be too expensive in the offchain worker miner context, but the signed staking-miner 100% need this.

@georgesdib
Copy link
Contributor Author

The main thing that I see missing is:

We are thinking of actually setting a MaxBackersPerWinner (e.g. 2048) enforcing it. This means that we 100% need that SortIntoBoundedSupports, and most importantly, the miner code (unisgned.rs) should use it.

We might need to play a bit of game here to allow the Miner to configure its behavior. Doing SortIntoBoundedSupports might be too expensive in the offchain worker miner context, but the signed staking-miner 100% need this.

I have rebased it off master in #11499

@kianenigma
Copy link
Contributor

Thanks! closing this then to keep the lists small.

@kianenigma kianenigma closed this May 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
Status: 👀 Might Revisit 👀
Development

Successfully merging this pull request may close these issues.

2 participants