This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Bounding ElectionProvider
#11229
Closed
Bounding ElectionProvider
#11229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
19 tasks
kianenigma
reviewed
Apr 19, 2022
kianenigma
reviewed
Apr 19, 2022
kianenigma
reviewed
Apr 19, 2022
kianenigma
reviewed
Apr 19, 2022
kianenigma
reviewed
Apr 19, 2022
kianenigma
reviewed
Apr 19, 2022
There was a problem hiding this comment.
Looks in the right direction, but please:
- Don't paginate anything in this PR, only bounding the return type of
elect. - Make this PR be based on top of Multi-block election part 0: Paginated election data provider #11105 to have a cleaner diff. You can select this at the top of the page in the github UI.
kianenigma
changed the base branch from
master
to
kiz-multi-election-pt0-paginated-data-provider
|
Closing this PR as I have rewritten it in #11242 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements Step 1 of paritytech/polkadot-sdk#461