Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

update pr-custom-review.yml #11169

Merged
merged 1 commit into from
Apr 7, 2022
Merged

update pr-custom-review.yml #11169

merged 1 commit into from
Apr 7, 2022

Conversation

joao-paulo-parity
Copy link
Contributor

⚠️ This PR does not replace #10951. The configuration first has to be committed to master for it to take effect in that PR. After this is merged, #10951 can still be used exclusively for updating the GitHub workflow file (it does not make sense to update both the configuration and the workflow files in a single pull request).

This PR implements the requirements discussed in paritytech/pr-custom-review#67. Feel free to comment there for any disagreements.

The other Substrate requirement missing from this file is implemented as a built-in check, therefore it should not be included here.

Updates .github/pr-custom-review.yml

@joao-paulo-parity joao-paulo-parity added A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Apr 5, 2022
@joao-paulo-parity joao-paulo-parity requested a review from a team as a code owner April 5, 2022 13:31
@joao-paulo-parity joao-paulo-parity mentioned this pull request Apr 5, 2022
Merged
@sergejparity sergejparity requested review from a team April 6, 2022 13:13
@TriplEight TriplEight merged commit f98ef8a into master Apr 7, 2022
@TriplEight TriplEight deleted the jp/pr-custom-review-config branch April 7, 2022 14:23
@joao-paulo-parity joao-paulo-parity mentioned this pull request Apr 7, 2022
Merged
acatangiu pushed a commit to acatangiu/substrate that referenced this pull request Apr 8, 2022
@joao-paulo-parity @acatangiu
update pr-custom-review.yml (paritytech#11169)
83df856 
syntax in accordance to https://github.com/paritytech/pr-custom-review/tree/5814820aa0e5d35412f31dc02f9d130a8b138cae#configuration-syntax
rules in accordance to https://github.com/paritytech/pr-custom-review/blob/da1d81b9fd39705cc8b37f59235283801c818708/rules.md
DaviRain-Su pushed a commit to octopus-network/substrate that referenced this pull request Aug 23, 2022
@joao-paulo-parity @DaviRain-Su
update pr-custom-review.yml (paritytech#11169)
00f728d 
syntax in accordance to https://github.com/paritytech/pr-custom-review/tree/5814820aa0e5d35412f31dc02f9d130a8b138cae#configuration-syntax
rules in accordance to https://github.com/paritytech/pr-custom-review/blob/da1d81b9fd39705cc8b37f59235283801c818708/rules.md
ark0f pushed a commit to gear-tech/substrate that referenced this pull request Feb 27, 2023
@joao-paulo-parity @ark0f
update pr-custom-review.yml (paritytech#11169)
d812ebd 
syntax in accordance to https://github.com/paritytech/pr-custom-review/tree/5814820aa0e5d35412f31dc02f9d130a8b138cae#configuration-syntax
rules in accordance to https://github.com/paritytech/pr-custom-review/blob/da1d81b9fd39705cc8b37f59235283801c818708/rules.md
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bkchr bkchr bkchr approved these changes

@TriplEight TriplEight TriplEight approved these changes

@sergejparity sergejparity sergejparity approved these changes

Assignees
No one assigned
Labels
A2-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joao-paulo-parity @bkchr @TriplEight @sergejparity