-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Conversation
|
For the record I'll not be able to deprecate the approval rules on processbot (paritytech/parity-processbot#356) until pr-custom-review is available on Polkadot and Cumulus as well. At the same time I intuit that processbot and pr-custom-review do not block nor obstruct each other. |
Co-authored-by: Denis Pisarev <[email protected]>
#10968 created to deploy config file for this GHA as this PR cannot proceed without it. |
I'd alter that to: at least two team leads, one of whom is in the group @gavofyork @shawntabrizi, @rphmeier and @bkchr. I think otherwise it adds too much friction. Same for the 🔒-lines in Substrate. |
In light of
I've noticed there hasn't been a consensus on the rules' definitions compared to what's implemented in this PR (which is closer to what we were predicting during paritytech/pr-custom-review#32). #10951 (comment) particularly can be interpreted as divergence from the initial requirements in https://github.com/paritytech/ci_cd/issues/233#issue-1026394650 which, I assumed, would not change; if these requirements would change, since they are related to built-in checks, then not only the rules but also the implementation of pr-custom-review needs to change as well. Based on how the discussion went so far and how many parties are involved, I also think it's less productive to have this same back-and-forth on each pull request for each repository. I would prefer if we were to define rules for all repositories upfront first and then only move to the implementation once a consensus has been reached, instead of trying to both discuss and implement at the same time like in this PR. Given the arguments above I've suggested to @TriplEight that it would be more efficient to discuss the rules in English terms, in a separate PR, using the following format as an example:
I plan to soon propose a separate discussion PR in https://github.com/paritytech/pr-custom-review, so I suggest we move this PR to Draft in the meantime. |
Co-authored-by: João Paulo Silva de Souza <[email protected]>
Co-authored-by: João Paulo Silva de Souza <[email protected]>
* Add GHA for custom PR review * Change FILES rule settings * Update rules according to feedback * Update .github/pr-custom-review.yml Co-authored-by: Denis Pisarev <[email protected]> * CI: PRCR new 🔒 team is locks-review * CI: rename a confusing step * Update .github/workflows/pr-custom-review.yml Co-authored-by: João Paulo Silva de Souza <[email protected]> * CI: use a proper new team for as per discussion with @drahnr it was decided to create a dedicated team for reviewing runtime files * Update pr-custom-review.yml * Update .github/workflows/pr-custom-review.yml Co-authored-by: João Paulo Silva de Souza <[email protected]> * Update .github/workflows/pr-custom-review.yml Co-authored-by: João Paulo Silva de Souza <[email protected]> Co-authored-by: Denis Pisarev <[email protected]> Co-authored-by: TriplEight <[email protected]> Co-authored-by: Denis Pisarev <[email protected]> Co-authored-by: João Paulo Silva de Souza <[email protected]>
* Add GHA for custom PR review * Change FILES rule settings * Update rules according to feedback * Update .github/pr-custom-review.yml Co-authored-by: Denis Pisarev <[email protected]> * CI: PRCR new 🔒 team is locks-review * CI: rename a confusing step * Update .github/workflows/pr-custom-review.yml Co-authored-by: João Paulo Silva de Souza <[email protected]> * CI: use a proper new team for as per discussion with @drahnr it was decided to create a dedicated team for reviewing runtime files * Update pr-custom-review.yml * Update .github/workflows/pr-custom-review.yml Co-authored-by: João Paulo Silva de Souza <[email protected]> * Update .github/workflows/pr-custom-review.yml Co-authored-by: João Paulo Silva de Souza <[email protected]> Co-authored-by: Denis Pisarev <[email protected]> Co-authored-by: TriplEight <[email protected]> Co-authored-by: Denis Pisarev <[email protected]> Co-authored-by: João Paulo Silva de Souza <[email protected]>
This PR enables the configuration in pr-custom-review.yml for the rules discussed in paritytech/pr-custom-review#67. Feel free to comment there for any suggestions or disagreements.
In short: Action will monitor PRs for changes defined in rules and if such detected will request review from defined in rule users/teams and will monitor review status by setting by setting
Check reviews
GitHub Status Check (needs to be enabled in repository settings) on PR which will pass once all needed approvals received.This is how it requests the relevant reviewers
Example output of the job failed by the unfulfilled request for reviewing the 🔒ed line.