This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
draft: attempt to fix code duplication and AllPallets footgun #10046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
A3-in_progress
gui1117
changed the title
|
merged into #10043 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #9105
Currently in executive we always handle system pallet manually, instead it should be considered as other pallet.
Also this fix the case where system pallet defines some offchain worker. currently the manual handling of the offchain worker hook for system pallet is missing.
The only usage of
AllPalletsin substrate is for executive type. So this PR changesAllPalletstype to include frame system pallet. and modify executive in order not to call the hook 2 times for system pallet.