Rename AllPallets to AllPalletsWithoutSystem and AllPalletsWithSystem to AllPallet

[shawntabrizi]

Let's remove one more footgun.

Where is AllPalletWithoutSystem useful?

cc @thiolliere

[gui1117]

yes, but we have to careful that people don't miss this change, and execute some system stuff 2 times.
Maybe for a better transition we should do: rename AllPalletsWithSystem to AllPallet in another release or find another name which doesn't conflict, like AllPalletsTuple or PalletsTuple while deprecating AllPallets

[KiChjang]

I like to be more pedantic and have AllPalletsWithSystem and AllPalletsWithoutSystem. That way there's no way people can mistake one for the other.

[TomaszWaszczyk]

The issue relies only on renaming types AllPallets and AllPalletsWithSystem or also some changes in logic? What version of changes should be implemented, version of @shawntabrizi or @KiChjang ?

I look for practical experience in Rust and I am willing to implement simple tasks.

[gui1117]

IMO we should do KiChjang suggestion, otherwise people will very likely miss the breaking change.

[gui1117]

Or a new name with deprecated old type alias

type AllPalletsTuple = ..
type AllPalletsTypleWithoutSystem = ..
#[deprecated(..)]
type AllPallets = AllPalletsTupleWithoutSystem
#[deprecated(..)]
type AllPalletsWithSystem = AllPalletsTuple