Add Javascript test setup #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate and install the 'package.json' file required to correctly identify the Javascript standard used for revive-wasm.
ghost
force-pushed
the
add-js-test-infra
branch
from
8b06a4f
to
593271b
Compare
Closed
|
@wpt967 what is the exact status of this PR? We should avoid letting it rot for too long and try getting it merged soon. After #66, we can investigate if the in-browser memory limitations are still bad enough. But it doesn't block this work from being finished. Can we bring this PR to a state where the compiler works fine in node where we there are basically no resource constraint? There was also #26. IIRC the only thing missing there was proper testing on the CI. |
|
Defunct, closed. |
ghost
closed this
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a basic set up for running revive-wasm tests. This is intended as an addition the the revive on wasm work being done in smiasojed/revive.git.