Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Conversation

drskalman
Copy link
Contributor

@drskalman drskalman commented Aug 2, 2023

Companion for paritytech/substrate#14373

cumulus companion: paritytech/cumulus#2739

@davxy davxy requested a review from Lederstrumpf August 2, 2023 10:44
@paritytech-ci paritytech-ci requested review from a team August 2, 2023 10:44
@davxy davxy added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. labels Aug 2, 2023
@davxy davxy requested review from michalkucharczyk and a team August 2, 2023 10:48
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/3316192

@davxy davxy requested a review from andresilva August 2, 2023 12:07
@paritytech-ci paritytech-ci requested a review from a team August 2, 2023 13:34
@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Statuses failed for ad49fa0

@dmitry-markin
Copy link
Contributor

This PR is currently blocking cumulus CI, trying restarting gitlab-check-dependent-cumulus.

@dmitry-markin
Copy link
Contributor

dmitry-markin commented Aug 2, 2023

Set paritytech/cumulus#2739 as this PR's companion, otherwise we are stuck.

@paritytech paritytech deleted a comment from paritytech-processbot bot Aug 2, 2023
@paritytech paritytech deleted a comment from paritytech-processbot bot Aug 2, 2023
@paritytech paritytech deleted a comment from paritytech-processbot bot Aug 2, 2023
@paritytech paritytech deleted a comment from paritytech-processbot bot Aug 2, 2023
@dmitry-markin
Copy link
Contributor

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot paritytech-processbot bot merged commit 2fe8274 into paritytech:master Aug 2, 2023
5 checks passed
@davxy
Copy link
Member

davxy commented Aug 2, 2023

@drskalman
Copy link
Contributor Author

Merging certainly seems harder than the developing the feature itself :-) For one, it is a highly non-deterministic time-sensitive process :-)

vstakhov pushed a commit that referenced this pull request Aug 3, 2023
* rename BEEFY `crypto` →`ecdsa_crypto`

* - bump up `BeefyApi` to version 3
- deal with `PeerId` error.

* update BEEFY dependency names for `fake-runtime` and `chain_spec`
revert Cargo.toml

* cargo fmt

* Use master Cargo.lock

* update lockfile for {"substrate"}

---------

Co-authored-by: Davide Galassi <[email protected]>
Co-authored-by: parity-processbot <>
s0me0ne-unkn0wn pushed a commit that referenced this pull request Aug 15, 2023
* rename BEEFY `crypto` →`ecdsa_crypto`

* - bump up `BeefyApi` to version 3
- deal with `PeerId` error.

* update BEEFY dependency names for `fake-runtime` and `chain_spec`
revert Cargo.toml

* cargo fmt

* Use master Cargo.lock

* update lockfile for {"substrate"}

---------

Co-authored-by: Davide Galassi <[email protected]>
Co-authored-by: parity-processbot <>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants