Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Companion for substrate 14373 #2962

Closed
wants to merge 1 commit into from
Closed

Companion for substrate 14373 #2962

wants to merge 1 commit into from

Conversation

davxy
Copy link
Member

@davxy davxy commented Aug 2, 2023

@davxy davxy requested a review from a team August 2, 2023 07:06
@davxy davxy added B0-silent Changes should not be mentioned in any release notes A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit labels Aug 2, 2023
@davxy davxy mentioned this pull request Aug 2, 2023
Merged
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/cumulus/-/jobs/3313468

@davxy davxy requested a review from acatangiu August 2, 2023 07:25
@michalkucharczyk michalkucharczyk requested a review from a team August 2, 2023 08:52
@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Statuses failed for 3c9d96c

@dmitry-markin
Copy link
Contributor

This PR is blocking cumulus CI. Cherry-picked to #2739 which is needed to fix Cumulus builds.

@davxy
Copy link
Member Author

davxy commented Aug 2, 2023

This PR is blocking cumulus CI. Cherry-picked to #2739 which is needed to fix Cumulus builds.

Yeah. I'll wait for your cumulus companion PR to be merged. Otherwise we are stuck

@dmitry-markin dmitry-markin mentioned this pull request Aug 2, 2023
Merged
@dmitry-markin
Copy link
Contributor

We also have problems with paritytech/polkadot#7572. Going to switch cumulus companion there to my cumulus PR which already include your changes.

@davxy
Copy link
Member Author

davxy commented Aug 2, 2023

We also have problems with paritytech/polkadot#7572. Going to switch cumulus companion there to my cumulus PR which already include your changes.

@dmitry-markin in this case you probably need to pull in the changes introduced by #2841

@davxy
Copy link
Member Author

davxy commented Aug 2, 2023

Superseeded by #2739

@davxy davxy closed this Aug 2, 2023
@davxy davxy deleted the davxy-companion-for-14373 branch August 2, 2023 16:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andresilva andresilva andresilva approved these changes

@kpp kpp kpp approved these changes

@Lederstrumpf Lederstrumpf Lederstrumpf approved these changes

@michalkucharczyk michalkucharczyk michalkucharczyk approved these changes

@acatangiu acatangiu Awaiting requested review from acatangiu

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@davxy @paritytech-cicd-pr @dmitry-markin @andresilva @kpp @Lederstrumpf @michalkucharczyk