Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Offences Migration v1: Removes ReportsByKindIndex #7114

Merged
merged 5 commits into from
Apr 26, 2023
Merged

Offences Migration v1: Removes ReportsByKindIndex #7114

merged 5 commits into from
Apr 26, 2023

Conversation

gupnik
Copy link
Contributor

@gupnik gupnik commented Apr 22, 2023

@paritytech-ci paritytech-ci requested review from a team April 22, 2023 04:26
@gupnik gupnik mentioned this pull request Apr 22, 2023
Merged
@gupnik gupnik added A0-please_review Pull request needs code review. D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited. E0-runtime_migration PR introduces code that might require downstream chains to run a runtime upgrade. C7-high PR touches the given topic and has a high impact on builders. B1-note_worthy Changes should be noted in the release notes T1-runtime This PR/Issue is related to the topic “runtime”. labels Apr 22, 2023
@paritytech-ci paritytech-ci requested a review from a team April 22, 2023 07:57
andresilva
andresilva previously requested changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@andresilva andresilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing kusama migration

@paritytech-ci paritytech-ci requested a review from a team April 25, 2023 11:15
@gupnik
Copy link
Contributor Author

gupnik commented Apr 25, 2023

Missing kusama migration

Added it @andresilva

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable
Logs: https://gitlab.parity.io/parity/mirrors/polkadot/-/jobs/2728998

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Statuses failed for 4897f4f

@gupnik
Copy link
Contributor Author

gupnik commented Apr 25, 2023

bot merge

@paritytech-processbot
Copy link

Error: Statuses failed for 4897f4f

@gupnik
Copy link
Contributor Author

gupnik commented Apr 25, 2023

bot merge

@paritytech-processbot
Copy link

Error: Statuses failed for 4897f4f

@ggwpez
Copy link
Member

ggwpez commented Apr 25, 2023 •
edited
Loading

try-runtime will not go green, so we have to temp. disable it until paritytech/substrate#14006.

@ggwpez
Temp allow try-runtime to fail
c2de80e 
... until paritytech/substrate#14006 is done.

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
@ggwpez ggwpez requested review from a team and chevdor as code owners April 25, 2023 16:26
@paritytech-ci paritytech-ci requested a review from a team April 25, 2023 16:26
@paritytech-ci paritytech-ci requested a review from a team April 25, 2023 16:29
@ggwpez ggwpez mentioned this pull request Apr 25, 2023
Closed
@ggwpez
Copy link
Member

ggwpez commented Apr 25, 2023

bot merge

@paritytech-processbot
Copy link

Error: 1 review requesting changes and 6 approving reviews by reviewers with write access.

@ggwpez ggwpez requested a review from andresilva April 25, 2023 18:37
@ggwpez
Copy link
Member

ggwpez commented Apr 25, 2023

bot merge

@paritytech-processbot
Copy link

Waiting for commit status.

@paritytech-processbot
Copy link

Merge cancelled due to error. Error: 1 review requesting changes and 6 approving reviews by reviewers with write access.

@ggwpez ggwpez enabled auto-merge (squash) April 25, 2023 18:38
@ggwpez ggwpez disabled auto-merge April 25, 2023 18:38
@ggwpez
Copy link
Member

ggwpez commented Apr 25, 2023

bot merge force

@paritytech-processbot
Copy link

Error: 1 review requesting changes and 6 approving reviews by reviewers with write access.

@gupnik
Copy link
Contributor Author

gupnik commented Apr 26, 2023

bot merge force

@paritytech-processbot
Copy link

Error: 1 review requesting changes and 6 approving reviews by reviewers with write access.

@sam0x17 sam0x17 dismissed andresilva’s stale review April 26, 2023 03:49

changes have been addressed and merge is blocked until this review is dismissed

@sam0x17
Copy link
Contributor

sam0x17 commented Apr 26, 2023

bot merge force

@paritytech-processbot paritytech-processbot bot merged commit 254c521 into master Apr 26, 2023
@paritytech-processbot paritytech-processbot bot deleted the gupnik/reports-by-kind-migration branch April 26, 2023 04:08
ordian added a commit that referenced this pull request Apr 26, 2023
@ordian
Merge branch 'master' into ao-past-session-slashing-client
029796a 
* master:
  malus: dont panic on missing validation data (#6952)
  Offences Migration v1: Removes `ReportsByKindIndex` (#7114)
  Fix stalling dispute coordinator. (#7125)
  Fix rolling session window (#7126)
  [ci] Update buildah command and version (#7128)
  Bump assigned_slots params (#6991)
  XCM: Remote account converter (#6662)
  Rework `dispute-coordinator` to use `RuntimeInfo` for obtaining session information instead of `RollingSessionWindow` (#6968)
  Revert default proof size back to 64 KB (#7115)
ordian added a commit that referenced this pull request Apr 26, 2023
@ordian
Merge branch 'master' into ao-past-session-slashing-runtime
a58b144 
* master: (39 commits)
  malus: dont panic on missing validation data (#6952)
  Offences Migration v1: Removes `ReportsByKindIndex` (#7114)
  Fix stalling dispute coordinator. (#7125)
  Fix rolling session window (#7126)
  [ci] Update buildah command and version (#7128)
  Bump assigned_slots params (#6991)
  XCM: Remote account converter (#6662)
  Rework `dispute-coordinator` to use `RuntimeInfo` for obtaining session information instead of `RollingSessionWindow` (#6968)
  Revert default proof size back to 64 KB (#7115)
  update rocksdb to 0.20.1 (#7113)
  Reduce base proof size weight component to zero (#7081)
  PVF: Move PVF workers into separate crate (#7101)
  Companion for #13923 (#7111)
  update safe call filter (#7080)
  PVF: Don't dispute on missing artifact (#7011)
  XCM: Properly set the pricing for the DMP router (#6843)
  pvf: Update docs for PVF artifacts (#6551)
  Bump syn from 2.0.14 to 2.0.15 (#7093)
  Companion for substrate#13771 (#6983)
  Added Dwellir Nigeria bootnodes. (#7097)
  ...
@ggwpez ggwpez added C3-medium PR touches the given topic and has a medium impact on builders. and removed C7-high PR touches the given topic and has a high impact on builders. labels Apr 28, 2023
@mattheworris mattheworris mentioned this pull request Jun 12, 2023
Merged
16 tasks
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Closed
mattheworris added a commit to frequency-chain/frequency that referenced this pull request Jun 15, 2023
@mattheworris @rlaferla
Polkadot 0939 to 0942 upgrade (#1590)
6d9e542 
# Goal
The goal of this PR is upgrade Polkadot to v0.9.42

Polkadot Release Notes:
https://github.com/paritytech/polkadot/releases/tag/v0.9.42
https://github.com/paritytech/polkadot/releases/tag/v0.9.41
https://github.com/paritytech/polkadot/releases/tag/v0.9.40

Polkadot Release Analysis:

https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-41-v0-9-42/2828/1

Closes #1472 
Closes #1270 
Closes #1332 

# Discussion
- v0.9.40 was not working and there was evidence that changes in v0.9.42
were related, so we decided to jump ahead to v0.9.42
<!-- List discussion items -->
# Runtime Migrations Included
- [x] paritytech/polkadot#6937
- [x] paritytech/substrate#13715
- [x] paritytech/substrate#13936
- [x] paritytech/polkadot#7114
- [x] Further all migrations from 9.38+ are included:
paritytech/polkadot#7162)
# Checklist
- [x] Chain spec updated
- [ ] Custom RPC OR Runtime API added/changed? Updated js/api-augment.
- [ ] Design doc(s) updated
- [ ] Tests added
- [ ] Benchmarks added
- [x] Weights updated
# Tests Performed
- [x] `make ci-local` -- Passing (includes lint, docs, unit-test and
integration-test)
- [x] `make start-native` -- Successfully attached debugger when
creating MSA with Polkadot UI
- [x] `make start-relay` -- Docker Containers successfully started, but
too slow in emulation on Apple Silicon M2.
- [x] `make upgrade-local` -- Successfully started local relay network
and upgraded to a newer test runtime.
- [x] `make upgrade-local` -- Successfully updated a node running the
current version on branch `main`

---------

Co-authored-by: Frequency CI [bot] <[email protected]>
Co-authored-by: Matthew Orris <--help>
Co-authored-by: Robert La Ferla <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sam0x17 sam0x17 sam0x17 approved these changes

@rcny rcny rcny approved these changes

@ordian ordian ordian approved these changes

@bkchr bkchr bkchr approved these changes

@altaua altaua altaua approved these changes

@mateo-moon mateo-moon mateo-moon approved these changes

@chevdor chevdor Awaiting requested review from chevdor

@andresilva andresilva Awaiting requested review from andresilva

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C3-medium PR touches the given topic and has a medium impact on builders. D9-needsaudit 👮 PR contains changes to fund-managing logic that should be properly reviewed and externally audited. E0-runtime_migration PR introduces code that might require downstream chains to run a runtime upgrade. T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@gupnik @paritytech-cicd-pr @ggwpez @sam0x17 @andresilva @rcny @ordian @bkchr @altaua @mateo-moon