Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Sorting out Release 9380 to Present #7162

Closed
joepetrowski opened this issue May 2, 2023 · 7 comments
Closed

Sorting out Release 9380 to Present #7162

joepetrowski opened this issue May 2, 2023 · 7 comments
Assignees
@chevdor @EgorPopelyaev @coderobe
Labels
T3-relay_chain This PR/Issue is related to the relay chain. T8-release This PR/Issue is related to topics touching the release notes. U1-asap No need to stop dead in your tracks, however issue should be addressed as soon as possible.

Comments

@joepetrowski
Copy link
Contributor

Note: This issue only applies to runtimes and not any node releases.

The following runtimes have a bug in XCM v3 that was fixed in #7081 and #7115.

  • v938*
  • v939*
  • v940*

Polkadot is currently on v9370 and we are in the process of releasing 9420. However, some of these contain migrations, so we cannot skip them.

Notably:

Therefore, we have two options:

  1. Move all migrations from 9380 to present into the next release and mark all interim releases as unsafe. Propose v9420 as the next runtime upgrade on Polkadot.
  2. Backport 7081 and 7115 into all releases from v9380 to present and propose the new v9382 runtime on Polkadot.
@joepetrowski joepetrowski added U1-asap No need to stop dead in your tracks, however issue should be addressed as soon as possible. T3-relay_chain This PR/Issue is related to the relay chain. T8-release This PR/Issue is related to topics touching the release notes. labels May 2, 2023
@coderobe
Copy link
Contributor

coderobe commented May 2, 2023

instead of rereleasing several runtimes and delaying .42 enactment even further i would opt to go with making sure that one contains all these migrations and jumping ahead

cc @chevdor @EgorPopelyaev thoughts?

@EgorPopelyaev
Copy link
Contributor

I would also agree with Mara, cause several backports and new runtimes might create some confusion

@chevdor
Copy link
Contributor

chevdor commented May 2, 2023

There has been quite some work and many fixes in v0.9.42 so it sounds much healthier indeed to focus on getting the runtimes 9420 through asap than to patch older runtimes.

@joepetrowski
Copy link
Contributor Author

I'm cool with that decision, but I just looked at Polkadot. Can someone comb through the runtimes and see what migrations need to be brought forward for which chains into 9420?

Also remember Westend is on 9401 (so therefore up to date), and Kusama is on 9381 (so only needs 9391 and later migrations).

@coderobe
Copy link
Contributor

coderobe commented May 2, 2023

Also remember Westend is on 9401 (so therefore up to date), and Kusama is on 9381 (so only needs 9391 and later migrations).

The migrations should have guards on them, so we can simply bring all of them forward.
I'll go check which ones are missing and prepare a pr.

@coderobe
Copy link
Contributor

coderobe commented May 2, 2023

Looks like this is all, actually: 25fd5f5

This was referenced May 2, 2023
Merged
Closed
@chevdor
Copy link
Contributor

chevdor commented May 3, 2023

Closing:

  • the migrations since 9380 have been included into the new release
  • a special mention has been added to the release notes

@chevdor chevdor closed this as completed May 3, 2023
This was referenced May 3, 2023
Closed
Closed
Closed
@mattheworris mattheworris mentioned this issue Jun 12, 2023
Merged
16 tasks
mattheworris added a commit to frequency-chain/frequency that referenced this issue Jun 15, 2023
@mattheworris @rlaferla
Polkadot 0939 to 0942 upgrade (#1590)
6d9e542 
# Goal
The goal of this PR is upgrade Polkadot to v0.9.42

Polkadot Release Notes:
https://github.com/paritytech/polkadot/releases/tag/v0.9.42
https://github.com/paritytech/polkadot/releases/tag/v0.9.41
https://github.com/paritytech/polkadot/releases/tag/v0.9.40

Polkadot Release Analysis:

https://forum.polkadot.network/t/polkadot-release-analysis-v0-9-41-v0-9-42/2828/1

Closes #1472 
Closes #1270 
Closes #1332 

# Discussion
- v0.9.40 was not working and there was evidence that changes in v0.9.42
were related, so we decided to jump ahead to v0.9.42
<!-- List discussion items -->
# Runtime Migrations Included
- [x] paritytech/polkadot#6937
- [x] paritytech/substrate#13715
- [x] paritytech/substrate#13936
- [x] paritytech/polkadot#7114
- [x] Further all migrations from 9.38+ are included:
paritytech/polkadot#7162)
# Checklist
- [x] Chain spec updated
- [ ] Custom RPC OR Runtime API added/changed? Updated js/api-augment.
- [ ] Design doc(s) updated
- [ ] Tests added
- [ ] Benchmarks added
- [x] Weights updated
# Tests Performed
- [x] `make ci-local` -- Passing (includes lint, docs, unit-test and
integration-test)
- [x] `make start-native` -- Successfully attached debugger when
creating MSA with Polkadot UI
- [x] `make start-relay` -- Docker Containers successfully started, but
too slow in emulation on Apple Silicon M2.
- [x] `make upgrade-local` -- Successfully started local relay network
and upgraded to a newer test runtime.
- [x] `make upgrade-local` -- Successfully updated a node running the
current version on branch `main`

---------

Co-authored-by: Frequency CI [bot] <[email protected]>
Co-authored-by: Matthew Orris <--help>
Co-authored-by: Robert La Ferla <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chevdor chevdor

@EgorPopelyaev EgorPopelyaev

@coderobe coderobe

Labels
T3-relay_chain This PR/Issue is related to the relay chain. T8-release This PR/Issue is related to topics touching the release notes. U1-asap No need to stop dead in your tracks, however issue should be addressed as soon as possible.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chevdor @EgorPopelyaev @coderobe @joepetrowski