Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

update weights #6897

Merged
merged 4 commits into from
Mar 17, 2023
Merged

update weights #6897

merged 4 commits into from
Mar 17, 2023

Conversation

coderobe
Copy link
Contributor

weights for release 0.9.40, these will be backported into the release branch once approved & merged for master

@coderobe coderobe added A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. T1-runtime This PR/Issue is related to the topic “runtime”. B1-note_worthy Changes should be noted in the release notes labels Mar 16, 2023
@coderobe coderobe requested review from ggwpez and a team March 16, 2023 15:04
@coderobe coderobe mentioned this pull request Mar 16, 2023
Closed
14 tasks
ggwpez
ggwpez approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright when using comparison mode asymptotic in SWC. That mode was added since guess-worst is not a good representation for the average case because it always tries to find the worst increase.
image

@coderobe coderobe enabled auto-merge (squash) March 16, 2023 23:22
@coderobe coderobe merged commit 1f89e10 into master Mar 17, 2023
@coderobe coderobe deleted the coderobe/weights-40 branch March 17, 2023 10:09
@bkontur
Copy link
Contributor

bkontur commented Mar 17, 2023

why xcm weights are untouched?
https://github.com/paritytech/polkadot/tree/master/runtime/rococo/src/weights/xcm
https://github.com/paritytech/polkadot/tree/master/runtime/kusama/src/weights/xcm
https://github.com/paritytech/polkadot/tree/master/runtime/westend/src/weights/xcm

I see polkadot does not even have them:
https://github.com/paritytech/polkadot/tree/master/runtime/polkadot/src/weights

coderobe added a commit that referenced this pull request Mar 17, 2023
@coderobe
update weights (#6897)
256a9d2 
* polkadot: update weights

* westend: update weights

* kusama: update weights

* rococo: update weights
@ggwpez
Copy link
Member

ggwpez commented Mar 17, 2023 •
edited
Loading

@bkontur there are some files missing in the scripts.
We should probably add a verification script that checks the modification dates of all files containing "THIS FILE WAS AUTO-GENERATED USING THE SUBSTRATE BENCHMARK CLI" are recent to avoid this.

In the Polkadot case it looks like they are not needed, but check for yourself.
PS: opened #6906

ordian added a commit that referenced this pull request Mar 21, 2023
@ordian
Merge branch 'master' into ao-past-session-slashing-client
e90a31f 
* master:
  kusama: enable dispute slashes (#5974)
  Introduce OpenGov into Polkadot (#6701)
  introduce new well known key (#6915)
  [CI] Add bootnode checking CI jobs (#6889)
  Bump parity-db (#6921)
  Handling timers for repeat dispute participation requests (#6901)
  [Companion #13634] keystore overhaul (iter2) (#6913)
  tweak some pattern matches to address a new clippy warning
  Bump ci-linux image for rust 1.68
  Revert "Update orchestra to the recent version (#6854)" (#6916)
  Deprecate Currency: Companion for #12951 (#6780)
  changelog: template fixup (#6907)
  [Companion #13615] Keystore overhaul (#6892)
  update weights (#6897)
  Fix approval voting test (#6898)
  parachains-runtime: Less cloning! (#6896)
  Testing Reversion Speed on Dispute Concluded Against (#6880)
  remove duplicated arm and fix version index (#6884)
ordian added a commit that referenced this pull request Mar 21, 2023
@ordian
Merge branch 'master' into ao-past-session-slashing-runtime
a150569 
* master:
  kusama: enable dispute slashes (#5974)
  Introduce OpenGov into Polkadot (#6701)
  introduce new well known key (#6915)
  [CI] Add bootnode checking CI jobs (#6889)
  Bump parity-db (#6921)
  Handling timers for repeat dispute participation requests (#6901)
  [Companion #13634] keystore overhaul (iter2) (#6913)
  tweak some pattern matches to address a new clippy warning
  Bump ci-linux image for rust 1.68
  Revert "Update orchestra to the recent version (#6854)" (#6916)
  Deprecate Currency: Companion for #12951 (#6780)
  changelog: template fixup (#6907)
  [Companion #13615] Keystore overhaul (#6892)
  update weights (#6897)
  Fix approval voting test (#6898)
  parachains-runtime: Less cloning! (#6896)
  Testing Reversion Speed on Dispute Concluded Against (#6880)
  remove duplicated arm and fix version index (#6884)
@librelois librelois mentioned this pull request Apr 6, 2023
Closed
@github-actions github-actions bot mentioned this pull request Jun 15, 2023
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@EgorPopelyaev EgorPopelyaev EgorPopelyaev approved these changes

@ggwpez ggwpez ggwpez approved these changes

Assignees
No one assigned
Labels
A0-please_review Pull request needs code review. B1-note_worthy Changes should be noted in the release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. T1-runtime This PR/Issue is related to the topic “runtime”.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coderobe @bkontur @ggwpez @EgorPopelyaev