Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[Companion #13615] Keystore overhaul #6892

Merged
merged 10 commits into from
Mar 17, 2023

Conversation

davxy
Copy link
Member

@davxy davxy commented Mar 16, 2023

companion for: paritytech/substrate#13615

cumulus companion: paritytech/cumulus#2336

@davxy davxy self-assigned this Mar 16, 2023
@davxy davxy requested review from bkchr, a team, skunert and melekes March 16, 2023 09:33
@davxy davxy added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Mar 16, 2023
Copy link
Contributor

@skunert skunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only the one nit, Looks Good 👍

node/subsystem-util/src/lib.rs Outdated Show resolved Hide resolved
@davxy davxy requested a review from a team March 17, 2023 08:08
@davxy davxy added the D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit. label Mar 17, 2023
@davxy davxy requested a review from koute March 17, 2023 08:23
@davxy davxy changed the title [Companion] Keystore overhaul [Companion #13615] Keystore overhaul Mar 17, 2023
@paritytech-processbot
Copy link

Merge cancelled due to error. Error: Head SHA changed from 7b0e30d to 055511b

@davxy
Copy link
Member Author

davxy commented Mar 17, 2023

bot merge

@paritytech-processbot paritytech-processbot bot merged commit 97bd688 into master Mar 17, 2023
@paritytech-processbot paritytech-processbot bot deleted the davxy-companion-for-13615 branch March 17, 2023 12:09
ordian added a commit that referenced this pull request Mar 21, 2023
* master:
  kusama: enable dispute slashes (#5974)
  Introduce OpenGov into Polkadot (#6701)
  introduce new well known key (#6915)
  [CI] Add bootnode checking CI jobs (#6889)
  Bump parity-db (#6921)
  Handling timers for repeat dispute participation requests (#6901)
  [Companion #13634] keystore overhaul (iter2) (#6913)
  tweak some pattern matches to address a new clippy warning
  Bump ci-linux image for rust 1.68
  Revert "Update orchestra to the recent version (#6854)" (#6916)
  Deprecate Currency: Companion for #12951 (#6780)
  changelog: template fixup (#6907)
  [Companion #13615] Keystore overhaul (#6892)
  update weights (#6897)
  Fix approval voting test (#6898)
  parachains-runtime: Less cloning! (#6896)
  Testing Reversion Speed on Dispute Concluded Against (#6880)
  remove duplicated arm and fix version index (#6884)
ordian added a commit that referenced this pull request Mar 21, 2023
* master:
  kusama: enable dispute slashes (#5974)
  Introduce OpenGov into Polkadot (#6701)
  introduce new well known key (#6915)
  [CI] Add bootnode checking CI jobs (#6889)
  Bump parity-db (#6921)
  Handling timers for repeat dispute participation requests (#6901)
  [Companion #13634] keystore overhaul (iter2) (#6913)
  tweak some pattern matches to address a new clippy warning
  Bump ci-linux image for rust 1.68
  Revert "Update orchestra to the recent version (#6854)" (#6916)
  Deprecate Currency: Companion for #12951 (#6780)
  changelog: template fixup (#6907)
  [Companion #13615] Keystore overhaul (#6892)
  update weights (#6897)
  Fix approval voting test (#6898)
  parachains-runtime: Less cloning! (#6896)
  Testing Reversion Speed on Dispute Concluded Against (#6880)
  remove duplicated arm and fix version index (#6884)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. D3-trivial 🧸 PR contains trivial changes in a runtime directory that do not require an audit.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants