Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Add a paragraph about slashing in runtime disputes section from the guide #6531

Merged
merged 2 commits into from
Jan 11, 2023
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 14 additions & 1 deletion roadmap/implementers-guide/src/runtime/disputes.md
Original file line number Diff line number Diff line change
Expand Up @@ -123,4 +123,17 @@ applied:
as a measure not to import one sided disputes. A dispute is raised only if there are two opposing votes so if the
client is not sending them the dispute is a potential spam.
4. Remove unconfirmed disputes - if a dispute contains less votes than the byzantine threshold it is removed. This is
also a spam precaution. A legitimate client will send only confirmed disputes to the runtime.
also a spam precaution. A legitimate client will send only confirmed disputes to the runtime.

# Rewards and slashing

After the disputes are filtered the validators participating in the disputes are rewarded and more importantly the
offenders are slashed. Generally there can be two types of punishments:
* "against valid" - the offender claimed that a valid candidate is invalid.
* "for invalid" - the offender claimed that an invalid candidate is valid.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure it's worth mentioning such details at the moment. We might end up not using slashing for "for invalid" disputes and use "negative era points" instead. We'll probably have a full page for slashing eventually once the design is finalized. Also this section is named "Rewards and slashing", but no mention of rewards here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am in favor of keeping details for now as it shows current design and obsolete this once we have the design ironed out and that new page reflecting it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, we can adjust anytime.


Validators participating in inconclusive disputes are not slashed. Thanks to the applied filtering (described in the
tdimitrov marked this conversation as resolved.
Show resolved Hide resolved
previous section) one can be confident that there are no spam disputes in the runtime. So if a validator is not voting it
is due to another reason (e.g. being under DoS attack). There is no reason to punish such validators with a slash.

*Implementation note*: Slashing is performed in `process_checked_dispute_data` from `Disputes` pallet.