This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add a paragraph about slashing in runtime disputes section from the guide #6531
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -123,4 +123,19 @@ applied: | |
as a measure not to import one sided disputes. A dispute is raised only if there are two opposing votes so if the | ||
client is not sending them the dispute is a potential spam. | ||
4. Remove unconfirmed disputes - if a dispute contains less votes than the byzantine threshold it is removed. This is | ||
also a spam precaution. A legitimate client will send only confirmed disputes to the runtime. | ||
also a spam precaution. A legitimate client will send only confirmed disputes to the runtime. | ||
|
||
# Rewards and slashing | ||
|
||
After the disputes are filtered the validators participating in the disputes are rewarded and more importantly the | ||
offenders are slashed. Generally there can be two types of punishments: | ||
* "against valid" - the offender claimed that a valid candidate is invalid. | ||
* "for invalid" - the offender claimed that an invalid candidate is valid. | ||
|
||
A dispute might be inconclusive. This means that it has timed out without being confirmed. A confirmed dispute is one | ||
containing votes more than the byzantine threshold (1/3 of the active validators). Validators participating in | ||
inconclusive disputes are not slashed. Thanks to the applied filtering (described in the previous section) one can be | ||
confident that there are no spam disputes in the runtime. So if a validator is not voting it is due to another reason | ||
(e.g. being under DoS attack). There is no reason to punish such validators with a slash. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you! |
||
|
||
*Implementation note*: Slashing is performed in `process_checked_dispute_data` from `Disputes` pallet. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure it's worth mentioning such details at the moment. We might end up not using slashing for "for invalid" disputes and use "negative era points" instead. We'll probably have a full page for slashing eventually once the design is finalized. Also this section is named "Rewards and slashing", but no mention of rewards here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am in favor of keeping details for now as it shows current design and obsolete this once we have the design ironed out and that new page reflecting it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, we can adjust anytime.