This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
BlockId removal: refactor: StorageProvider #6160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It changes the arguments of `Backend::StorageProvider` trait from: block: `BlockId<Block>` to: hash: `&Block::Hash`
michalkucharczyk
added
A0-please_review
bkchr
approved these changes
Oct 18, 2022
| fn storage( | ||
| &self, | ||
| id: &BlockId<Block>, | ||
| hash: &<Block as BlockT>::Hash, |
There was a problem hiding this comment.
Suggested change
| hash: &<Block as BlockT>::Hash, | |
| hash: &Block::Hash, |
You don't need to fully qualify the trait.
There was a problem hiding this comment.
This won't compile:
--> node/client/src/lib.rs:427:10
|
427 | hash: &Block::Hash,
| ^^^^^^^^^^^ help: use fully-qualified syntax: `<sp_runtime::generic::Block<sp_runtime::generic::Header<u32, BlakeTwo256>, OpaqueExtrinsic> as Trait>::Hash`
There was a problem hiding this comment.
Ahh yeah, I thought Block is a generic type here. However, it is the actual type. So, this doesn't work. Sorry!
altonen
approved these changes
Oct 18, 2022
dmitry-markin
approved these changes
Oct 18, 2022
skunert
approved these changes
Oct 18, 2022
bkchr
reviewed
Oct 18, 2022
| fn storage( | ||
| &self, | ||
| id: &BlockId<Block>, | ||
| hash: &<Block as BlockT>::Hash, |
There was a problem hiding this comment.
Ahh yeah, I thought Block is a generic type here. However, it is the actual type. So, this doesn't work. Sorry!
|
Waiting for commit status. |
ordian
added a commit
that referenced
this pull request
Oct 21, 2022
* master: (21 commits) try and fix build (#6170) Companion for EPM duplicate submissions (#6115) Bump docker/setup-buildx-action from 2.0.0 to 2.1.0 (#6141) companion for #12212 (#6162) Bump substrate (#6164) BlockId removal: refactor: StorageProvider (#6160) availability-recovery: use `IfDisconnected::TryConnect` for chunks (#6081) Update clap to version 4 (#6128) Add `force_open_hrmp_channel` Call (#6155) Fix fuzzing builds xcm-fuzz and erasure-coding fuzzer (#6153) BlockId removal refactor: Backend::state_at (#6149) First round of implementers guide fixes (#6146) bump zombienet version (#6142) lingua.dic is not managed by CI team (#6148) pallet-mmr: RPC and Runtime APIs work with block numbers (#6072) Separate preparation timeouts for PVF prechecking and execution (#6139) Malus: add disputed block percentage (#6100) refactor grid topology to expose more info to subsystems (#6140) Manual Para Lock (#5451) Expose node subcommands in Malus CLI (#6135) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It changes the arguments of
Backend::StorageProvidertrait from:block:
BlockId<Block>to: hash:&Block::HashCompanion for: paritytech/substrate#12510
cumulus companion: paritytech/cumulus#1770