Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

zombienet: BEEFY and MMR test #5840

Merged
merged 1 commit into from
Aug 4, 2022
Merged

zombienet: BEEFY and MMR test #5840

merged 1 commit into from
Aug 4, 2022

Conversation

acatangiu
Copy link
Contributor

Test BEEFY voting and finality.

In the future will test:

  • BEEFY RPCs,
  • MMR proofs,
  • BEEFY block import,
  • BEEFY justification syncing.

(Test assumes Rococo sessions of 1 minute)

Draft status

Waiting for zombienet release containing paritytech/zombienet#276.

@acatangiu acatangiu added A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders. labels Jul 29, 2022
@acatangiu acatangiu self-assigned this Jul 29, 2022
@pepoviola
Copy link
Contributor

Hi @acatangiu, I just created a new release (https://github.com/paritytech/zombienet/releases/tag/v1.2.50) that contains paritytech/zombienet#276. Thanks!

pepoviola
pepoviola approved these changes Aug 1, 2022
View reviewed changes
Copy link
Contributor

@pepoviola pepoviola left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add the test in the gitlab-ci.yml file, I can add it if you want.
Thanks!

@acatangiu acatangiu mentioned this pull request Aug 1, 2022
Closed
@svyatonik svyatonik mentioned this pull request Aug 25, 2023
Closed
2 tasks
@acatangiu
Copy link
Contributor Author

You need to add the test in the gitlab-ci.yml file, I can add it if you want. Thanks!

Added, please take a look.

@acatangiu acatangiu marked this pull request as ready for review August 2, 2022 10:49
@acatangiu acatangiu requested a review from a team as a code owner August 2, 2022 10:49
@paritytech-ci paritytech-ci requested a review from a team August 2, 2022 10:49
@acatangiu
Copy link
Contributor Author

@paritytech-ci please review

@paritytech-ci paritytech-ci requested a review from a team August 3, 2022 16:12
sandreim
sandreim approved these changes Aug 4, 2022
View reviewed changes
Copy link
Contributor

@sandreim sandreim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I also suggest creating an issue for the leftover todos

@acatangiu acatangiu merged commit 3d78ec6 into paritytech:master Aug 4, 2022
ordian added a commit that referenced this pull request Aug 4, 2022
@ordian
Merge branch 'master' into ao-disputes-offences-runtime
0c2559c 
* master:
  Companion for substrate#11962 (#5852)
  zombienet: BEEFY and MMR test (#5840)
  Run benchmarks with --steps=2 (#5853)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pepoviola pepoviola pepoviola approved these changes

@svyatonik svyatonik svyatonik approved these changes

@radupopa2010 radupopa2010 radupopa2010 approved these changes

@alvicsam alvicsam alvicsam approved these changes

@sandreim sandreim sandreim approved these changes

@andresilva andresilva Awaiting requested review from andresilva

Assignees

@acatangiu acatangiu

Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@acatangiu @pepoviola @svyatonik @radupopa2010 @alvicsam @sandreim