You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
acatangiu opened this issue
Aug 1, 2022
· 0 comments
· Fixed by #11959
Assignees
Labels
I3-bugThe node fails to follow expected behavior.U1-asapNo need to stop dead in your tracks, however issue should be addressed as soon as possible.Z1-easyCan be fixed primarily by duplicating and adapting code by an intermediate coder
// TODO: when adding SYNC protocol, fire up a request for justification for this
// mandatory block here.
}
But zombienet tests in paritytech/polkadot#5840 show that is not always the case, sometimes the authorities_change block is in the middle of a sub-chain of blocks finalized at once.
Solution
Voter should drop above assumption and explicitly check if validator set changed, and if so, walk the tree_route in the finality notification to find and process the finalized block containing authorities_change digest.
The text was updated successfully, but these errors were encountered:
acatangiu
added
I3-bug
The node fails to follow expected behavior.
U1-asap
No need to stop dead in your tracks, however issue should be addressed as soon as possible.
Z1-easy
Can be fixed primarily by duplicating and adapting code by an intermediate coder
labels
Aug 1, 2022
acatangiu
changed the title
client/beefy: walk finality tree_route looking for session change header digest
client/beefy: ensure mandatory blocks on session changes by explicitly walking finality tree_routeNov 11, 2022
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
I3-bugThe node fails to follow expected behavior.U1-asapNo need to stop dead in your tracks, however issue should be addressed as soon as possible.Z1-easyCan be fixed primarily by duplicating and adapting code by an intermediate coder
Bug
Right now BEEFY voter assumes it's getting explicit finality notifications for any block containing
authorities_change
digest:substrate/client/beefy/src/worker.rs
Lines 349 to 353 in 4d59804
But zombienet tests in paritytech/polkadot#5840 show that is not always the case, sometimes the
authorities_change
block is in the middle of a sub-chain of blocks finalized at once.Solution
Voter should drop above assumption and explicitly check if validator set changed, and if so, walk the
tree_route
in the finality notification to find and process the finalized block containingauthorities_change
digest.The text was updated successfully, but these errors were encountered: