This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
Update substrate master #411
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gui1117
added
the
A3-in_progress
gui1117
commented
Aug 29, 2019
| @@ -54,7 +54,7 @@ use sr_staking_primitives::SessionIndex; | |||
| use srml_support::{ | |||
| parameter_types, construct_runtime, traits::{SplitTwoWays, Currency} | |||
| }; | |||
| use im_online::AuthorityId as ImOnlineId; | |||
| use im_online::sr25519::{AuthorityId as ImOnlineId}; | |||
There was a problem hiding this comment.
we use this one in node runtime in substrate though I don't know which one we want here
There was a problem hiding this comment.
might help
gui1117
added
A0-please_review
|
@thiolliere looks like it builds ok. Once this is ready please backport changes to |
gavofyork
approved these changes
Sep 2, 2019
I'm not sure I understand, this PR is ready to me, I'm working on the backport now EDIT: my bad I didn't update my top comment |
gui1117
added a commit
that referenced
this pull request
Sep 2, 2019
* in progress impl * im_online authorityid * fix * fix * use polkadot-master * trigger CI * trigger CI * fix removal * storage reorganize included * lock version
gavofyork
pushed a commit
that referenced
this pull request
Sep 3, 2019
* Update to latest Substrate (#407) * Update to latest Substrate * Fix main.rs * Update substrate master (#411) * in progress impl * im_online authorityid * fix * fix * use polkadot-master * trigger CI * trigger CI * fix removal * storage reorganize included * lock version * remove unused * increment spec version * ICMP message-routing gossip (#304) * core logic for ICMP gossip * refactor gossip to make more extension friendly * move files aroun * extract attestation-gossip logic to its own module * message validation and broadcast logic * fix upstream crates' compilation * add a test * another test for overlapping * Some grammar and phrasing tweaks Co-Authored-By: Luke Schoen <[email protected]> * add since parameter to ingress runtime API * broadcast out known unrouted message queues * fix compilation of service and collator * remove useless index_mapping * some tests for icmp propagation * fix decoding bug and test icmp queue validation * simplify engine-id definition Co-Authored-By: Sergei Pepyakin <[email protected]> * address some grumbles * some cleanup of old circulation code * give network a handle to extrinsic store on startup * an honest collator ensures data available as well * address some grumbles * add docs; rename the attestation session to "leaf work" * module docs * move gossip back to gossip.rs * clean up and document attestation-gossip a bit * some more docs on the availability store * store all outgoing message queues in the availability store * filter `Extrinsic` out of validation crate * expunge Extrinsic from network * expunge Extrinsic from erasure-coding * expunge Extrinsic from collator * expunge from adder-collator * rename ExtrinsicStore to AvailabilityStore everywhere * annotate and clean up message-routing tests
tomusdrw
pushed a commit
that referenced
this pull request
Mar 26, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syntax of deposit_event have changed.
Ready to merge