Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

Update to latest Substrate #407

Merged
merged 2 commits into from
Aug 27, 2019
Merged

Conversation

tomaka
Copy link
Contributor

@tomaka tomaka commented Aug 27, 2019

Integrates paritytech/substrate#3382

Its ends up having more trait requirements than I anticipated because of the Worker implementation that requires concrete types (and not a generic service), and we might need some cleanup in the future.

@tomaka tomaka added the A0-please_review Pull request needs code review. label Aug 27, 2019
@tomaka tomaka requested a review from bkchr August 27, 2019 13:29
@tomaka
Copy link
Contributor Author

tomaka commented Aug 27, 2019

The changes in service.rs consist of three things:

  • Code has been copy-pasted with almost no alteration from the macro to the new_* functions.
  • The inherent_data_providers, import_setup and tasks_to_spawn variables are now local variables used only during the building (as intended), and are no longer stored within the configuration.
  • Removed the PolkadotService trait. I initially tried to do impl<T> PolkadotService for T where T: AbstractService<Block = Block, ...all the requirements...>, but it turns out to be impossible to express.

@bkchr bkchr merged commit 67e1ba1 into paritytech:master Aug 27, 2019
@tomaka tomaka deleted the update-substrate-20190827 branch August 27, 2019 13:57
gui1117 pushed a commit that referenced this pull request Sep 2, 2019
* Update to latest Substrate

* Fix main.rs
gavofyork pushed a commit that referenced this pull request Sep 3, 2019
* Update to latest Substrate (#407)

* Update to latest Substrate

* Fix main.rs

* Update substrate master (#411)

* in progress impl

* im_online authorityid

* fix

* fix

* use polkadot-master

* trigger CI

* trigger CI

* fix removal

* storage reorganize included

* lock version

* remove unused

* increment spec version

* ICMP message-routing gossip (#304)

* core logic for ICMP gossip

* refactor gossip to make more extension friendly

* move files aroun

* extract attestation-gossip logic to its own module

* message validation and broadcast logic

* fix upstream crates' compilation

* add a test

* another test for overlapping

* Some grammar and phrasing tweaks

Co-Authored-By: Luke Schoen <[email protected]>

* add since parameter to ingress runtime API

* broadcast out known unrouted message queues

* fix compilation of service and collator

* remove useless index_mapping

* some tests for icmp propagation

* fix decoding bug and test icmp queue validation

* simplify engine-id definition

Co-Authored-By: Sergei Pepyakin <[email protected]>

* address some grumbles

* some cleanup of old circulation code

* give network a handle to extrinsic store on startup

* an honest collator ensures data available as well

* address some grumbles

* add docs; rename the attestation session to "leaf work"

* module docs

* move gossip back to gossip.rs

* clean up and document attestation-gossip a bit

* some more docs on the availability store

* store all outgoing message queues in the availability store

* filter `Extrinsic` out of validation crate

* expunge Extrinsic from network

* expunge Extrinsic from erasure-coding

* expunge Extrinsic from collator

* expunge from adder-collator

* rename ExtrinsicStore to AvailabilityStore everywhere

* annotate and clean up message-routing tests
imstar15 pushed a commit to imstar15/polkadot that referenced this pull request Aug 25, 2021
* Introduce the converter into the hub

* Parachain recognises Rococo governance body as admin

* Whitespace

* Use UsingComponents for fee payment in XCM

* Fixes

* Fixes for XCM permissions

* Remove encode_call test

* Fixes

* Fixes

* Fixes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants