Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xcm-builder: added logging for xcm filters/helpers/matchers/types (#2408) #7003

Open
wants to merge 61 commits into
base: master
Choose a base branch
from
Open

xcm-builder: added logging for xcm filters/helpers/matchers/types (#2408) #7003

wants to merge 61 commits into from

Conversation

ayevbeosa
Copy link
Contributor

@ayevbeosa ayevbeosa commented Dec 26, 2024 •
edited
Loading

Description

Added logs in pallet-xcm to help in debugging, fixes #2408, and in continuation of #4982

Checklist

@ayevbeosa ayevbeosa changed the title pallet-xcm: added logging for xcm filters/helpers/matchers/types (#2408) xcm-builder: added logging for xcm filters/helpers/matchers/types (#2408) Dec 26, 2024
@ayevbeosa ayevbeosa marked this pull request as ready for review December 27, 2024 05:43
@ayevbeosa ayevbeosa requested a review from a team as a code owner December 27, 2024 05:43
bkchr
bkchr reviewed Dec 27, 2024
View reviewed changes
Copy link
Member

@bkchr bkchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please change all these calls to follow the same pattern as shown by me in teh suggestions?

cumulus/parachains/runtimes/assets/common/src/fungible_conversion.rs Outdated Show resolved Hide resolved
cumulus/parachains/runtimes/assets/common/src/benchmarks.rs Outdated Show resolved Hide resolved
cumulus/parachains/runtimes/assets/common/src/benchmarks.rs Outdated Show resolved Hide resolved
cumulus/parachains/runtimes/assets/common/src/matching.rs Outdated Show resolved Hide resolved
ayevbeosa and others added 8 commits December 27, 2024 15:29
@ayevbeosa @bkchr
Update cumulus/parachains/runtimes/assets/common/src/fungible_convers…
b4bf289 
…ion.rs

Co-authored-by: Bastian Köcher <[email protected]>
@ayevbeosa @bkchr
Update cumulus/parachains/runtimes/assets/common/src/benchmarks.rs
61c41ed 
Co-authored-by: Bastian Köcher <[email protected]>
@ayevbeosa @bkchr
Update cumulus/parachains/runtimes/assets/common/src/benchmarks.rs
74ba6cc 
Co-authored-by: Bastian Köcher <[email protected]>
@ayevbeosa @bkchr
Update cumulus/parachains/runtimes/assets/common/src/matching.rs
5548e1e 
Co-authored-by: Bastian Köcher <[email protected]>
@ayevbeosa
Merge branch 'master' into ayevbeosa-more-xcm-logs
e2cc86c
Merge branch 'ayevbeosa-more-xcm-logs' of https://github.com/ayevbeos…
e9d8c5e 
…a/polkadot-sdk into ayevbeosa-more-xcm-logs
changed tracing call pattern
d32edd7
@ayevbeosa
Merge branch 'master' into ayevbeosa-more-xcm-logs
fcdda09
ayevbeosa and others added 16 commits January 3, 2025 10:23
@ayevbeosa @bkchr
Update cumulus/parachains/runtimes/assets/common/src/matching.rs
93a1053 
Co-authored-by: Bastian Köcher <[email protected]>
@ayevbeosa @bkchr
Update cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/src…
69a7d5d 
…/xcm_config.rs

Co-authored-by: Bastian Köcher <[email protected]>
@ayevbeosa @bkchr
Update cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/src…
0b77a97 
…/xcm_config.rs

Co-authored-by: Bastian Köcher <[email protected]>
@ayevbeosa @bkchr
Update polkadot/xcm/xcm-builder/src/barriers.rs
be37eba 
Co-authored-by: Bastian Köcher <[email protected]>
@ayevbeosa @bkchr
Update polkadot/xcm/xcm-builder/src/asset_exchange/single_asset_adapt…
37510e1 
…er/adapter.rs

Co-authored-by: Bastian Köcher <[email protected]>
@ayevbeosa @bkchr
Update polkadot/xcm/xcm-builder/src/asset_exchange/single_asset_adapt…
2cc0f36 
…er/adapter.rs

Co-authored-by: Bastian Köcher <[email protected]>
@ayevbeosa @bkchr
Update polkadot/xcm/xcm-builder/src/asset_exchange/single_asset_adapt…
994421a 
…er/adapter.rs

Co-authored-by: Bastian Köcher <[email protected]>
@ayevbeosa @bkchr
Update polkadot/xcm/xcm-builder/src/barriers.rs
86f3a73 
Co-authored-by: Bastian Köcher <[email protected]>
@ayevbeosa @bkchr
Update polkadot/xcm/xcm-builder/src/currency_adapter.rs
85b3b30 
Co-authored-by: Bastian Köcher <[email protected]>
@ayevbeosa @bkchr
Update polkadot/xcm/xcm-builder/src/fungible_adapter.rs
81b725b 
Co-authored-by: Bastian Köcher <[email protected]>
@ayevbeosa @bkchr
Update polkadot/xcm/xcm-builder/src/fungibles_adapter.rs
664a361 
Co-authored-by: Bastian Köcher <[email protected]>
@ayevbeosa @bkchr
Update polkadot/xcm/xcm-builder/src/nonfungible_adapter.rs
9625dab 
Co-authored-by: Bastian Köcher <[email protected]>
@ayevbeosa @bkchr
Update polkadot/xcm/xcm-builder/src/nonfungibles_adapter.rs
d6e9bb6 
Co-authored-by: Bastian Köcher <[email protected]>
@ayevbeosa @bkchr
Update polkadot/xcm/xcm-builder/src/routing.rs
24106b3 
Co-authored-by: Bastian Köcher <[email protected]>
@ayevbeosa @bkchr
Update polkadot/xcm/xcm-builder/src/weight.rs
3c05171 
Co-authored-by: Bastian Köcher <[email protected]>
@ayevbeosa
Merge branch 'master' into ayevbeosa-more-xcm-logs
34aca75
acatangiu
acatangiu reviewed Jan 9, 2025
View reviewed changes
Copy link
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pushing this forward, most of it is looking very good! 👍

Please also add tracing and debug logging for:

And more in comments below.

polkadot/xcm/xcm-builder/src/fungibles_adapter.rs Outdated Show resolved Hide resolved
cumulus/parachains/runtimes/assets/common/src/fungible_conversion.rs Outdated Show resolved Hide resolved
cumulus/parachains/runtimes/assets/common/src/matching.rs Outdated Show resolved Hide resolved
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/src/xcm_config.rs Outdated Show resolved Hide resolved
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/src/xcm_config.rs Outdated Show resolved Hide resolved
polkadot/xcm/xcm-builder/src/barriers.rs Outdated Show resolved Hide resolved
polkadot/xcm/xcm-builder/src/barriers.rs Outdated Show resolved Hide resolved
polkadot/xcm/xcm-builder/src/barriers.rs Outdated Show resolved Hide resolved
polkadot/xcm/xcm-builder/src/currency_adapter.rs Outdated Show resolved Hide resolved
polkadot/xcm/xcm-builder/src/nonfungible_adapter.rs Outdated Show resolved Hide resolved
acatangiu
acatangiu reviewed Jan 22, 2025
View reviewed changes
Copy link
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice @ayevbeosa!

Just have couple more nits and we're done 😄

cumulus/parachains/runtimes/assets/common/src/foreign_creators.rs Outdated Show resolved Hide resolved
cumulus/parachains/runtimes/assets/common/src/fungible_conversion.rs Outdated Show resolved Hide resolved
cumulus/parachains/runtimes/assets/common/src/matching.rs Outdated Show resolved Hide resolved
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/src/lib.rs Outdated Show resolved Hide resolved
cumulus/parachains/runtimes/bridge-hubs/bridge-hub-westend/src/lib.rs Outdated Show resolved Hide resolved
polkadot/xcm/xcm-builder/src/routing.rs Outdated Show resolved Hide resolved
polkadot/xcm/xcm-builder/src/weight.rs Outdated Show resolved Hide resolved
polkadot/xcm/xcm-builder/src/weight.rs Show resolved Hide resolved
polkadot/xcm/xcm-builder/src/weight.rs Outdated Show resolved Hide resolved
polkadot/xcm/xcm-builder/src/weight.rs Outdated Show resolved Hide resolved
acatangiu
acatangiu approved these changes Jan 23, 2025
View reviewed changes
Copy link
Contributor

@acatangiu acatangiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! Please make CI pass and we can merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acatangiu acatangiu acatangiu approved these changes

@bkchr bkchr bkchr approved these changes

Assignees
No one assigned
Labels
T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[XCM] don't ignore errors
3 participants
@ayevbeosa @bkchr @acatangiu