pallet-xcm: added useful error logs (#2408)

[ayevbeosa]

Added error logs in pallet-xcm to help in debugging, fixes #2408

TODO

• change log::error to tracing::error format for xcm-executor
• check existing logs, e.g. this one can be extended with more info tracing::error!(target: "xcm::reanchor", ?error, "Failed reanchoring with error");
• use tracing instead of log for pallet-xcm/src/lib.rs

Polkadot Address: 1Gz5aLtEu2n4jsfA6XwtZnuaRymJrDDw4kEGdNHTdxrpzrc

[acatangiu]

@ayevbeosa this is good, but does not yet fix #2408 - this PR only covers pallet-xcm right now - #2408 is referring to XCM errors across the whole stack.
A good starting point is to do the same for everything under https://github.com/paritytech/polkadot-sdk/tree/master/polkadot/xcm.

[ayevbeosa]

A good starting point is to do the same for everything under https://github.com/paritytech/polkadot-sdk/tree/master/polkadot/xcm.

Thanks @acatangiu, is it okay to do everything in this PR or I should break it in parts?

[acatangiu]

I think you can do it in same PR since they're not that many changes

[github-actions]

Review required! Latest push from author must always be reviewed

[acatangiu]

@ayevbeosa do you still plan on getting this over the finish line?

[ayevbeosa]

@ayevbeosa do you still plan on getting this over the finish line?

Sure! Asides resolving the merge conflict, is there anything else left?

[acatangiu]

Sure! Asides resolving the merge conflict, is there anything else left?

Nope, merge master and have CI passing and we'll merge it.

[acatangiu]

@ayevbeosa you need to add a new pr_4982.prdoc file with this PR, explaining the changes and "bumping" the affected crates.

e.g. https://github.com/paritytech/polkadot-sdk/blob/master/prdoc/pr_6023.prdoc

In your case you should have following crates bumping:

crates:
  - name: staging-xcm-executor
    bump: patch
  - name: pallet-xcm
    bump: patch

[ayevbeosa]

@ayevbeosa you need to add a new pr_4982.prdoc file with this PR, explaining the changes and "bumping" the affected crates.

e.g. https://github.com/paritytech/polkadot-sdk/blob/master/prdoc/pr_6023.prdoc

In your case you should have following crates bumping:

crates:
  - name: staging-xcm-executor
    bump: patch
  - name: pallet-xcm
    bump: patch

Alright, thanks

[bkontur]

@ayevbeosa Thank you for your contribution, please include your Polkadot address in the PR description. https://github.com/paritytech/substrate-tip-bot

[ayevbeosa]

@ayevbeosa Thank you for your contribution, please include your Polkadot address in the PR description. https://github.com/paritytech/substrate-tip-bot

Thank you, will do that!

[acatangiu]

/tip small

[substrate-tip-bot]

@acatangiu A referendum for a small (20 DOT) tip was successfully submitted for @ayevbeosa (1Gz5aLtEu2n4jsfA6XwtZnuaRymJrDDw4kEGdNHTdxrpzrc on polkadot).

Referendum number: 1233.

[substrate-tip-bot]

The referendum has appeared on Polkassembly.