Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable2412] Backport #6505 #6888

Merged
merged 2 commits into from
Dec 16, 2024
Merged

Conversation

paritytech-cmd-bot-polkadot-sdk[bot]

Backport #6505 into stable2412 from seadanda.

See the documentation on how to use this bot.

@paritytech-cmd-bot-polkadot-sdk
Copy link
Author

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin backport-6505-to-stable2412
git worktree add --checkout .worktree/backport-6505-to-stable2412 backport-6505-to-stable2412
cd .worktree/backport-6505-to-stable2412
git reset --hard HEAD^
git cherry-pick -x 459b4a6521d35f3e84a036262e64fa547a5b1ff4
git push --force-with-lease

@github-actions github-actions bot added the A3-backport Pull request is already reviewed well in another branch. label Dec 13, 2024
Copy link

This pull request is amending an existing release. Please proceed with extreme caution,
as to not impact downstream teams that rely on the stability of it. Some things to consider:

  • Backports are only for 'patch' or 'minor' changes. No 'major' or other breaking change.
  • Should be a legit fix for some bug, not adding tons of new features.
  • Must either be already audited or not need an audit.
Emergency Bypass

If you really need to bypass this check: add validate: false to each crate
in the Prdoc where a breaking change is introduced. This will release a new major
version of that crate and all its reverse dependencies and basically break the release.

Fix the broker pallet auto-renew benchmarks which have been broken since
reported in #6474.

Upon further investigation it turned out that the auto-renew
contribution to `rotate_sale` was always failing but the error was
mapped. This is also fixed at the cost of a bit of setup overhead.

Fixes #6474

TODO:
- [x] Re-run weights

---------

Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: command-bot <>
Co-authored-by: Bastian Köcher <[email protected]>
(cherry picked from commit 459b4a6)
@seadanda seadanda force-pushed the backport-6505-to-stable2412 branch from a7d0100 to 1071c05 Compare December 13, 2024 17:29
@seadanda seadanda marked this pull request as ready for review December 13, 2024 17:29
@seadanda seadanda requested a review from a team as a code owner December 13, 2024 17:29
@EgorPopelyaev EgorPopelyaev merged commit 4a31d1c into stable2412 Dec 16, 2024
189 of 197 checks passed
@EgorPopelyaev EgorPopelyaev deleted the backport-6505-to-stable2412 branch December 16, 2024 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A3-backport Pull request is already reviewed well in another branch.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants