Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pallet broker: some benchmarks are weightless for kitchensink runtime. Resulting in substrate weight being 0 #6474

Closed
gui1117 opened this issue Nov 14, 2024 · 1 comment · Fixed by #6505
Closed

pallet broker: some benchmarks are weightless for kitchensink runtime. Resulting in substrate weight being 0 #6474

gui1117 opened this issue Nov 14, 2024 · 1 comment · Fixed by #6505
Labels
T12-benchmarks This PR/Issue is related to benchmarking and weights.

Comments

@gui1117
Copy link
Contributor

gui1117 commented Nov 14, 2024 •
edited
Loading

enable_auto_renew and disable_auto_renew benchmarks result in Weightless when run against the kitchensink runtime. And also when run against the mock runtime.

It is not very ideal as we use kitchen sink to get some default weight and some general idea of the cost of the pallet calls.

You can see the weight info resulting from CI here: 4dfe581#diff-394c3120033a81905e5460398ad0d7245d7143d21069aeffb3cdf07b41eccc18

I believe it is weightless since: #4424

@Szegoo
@seadanda
@gui1117 gui1117 added the T12-benchmarks This PR/Issue is related to benchmarking and weights. label Nov 14, 2024
@seadanda
Copy link
Contributor

Yea the benchmark is broken - the prices are too low for the purchases. Working on a fix.

This was referenced Nov 15, 2024
Merged
Merged
github-merge-queue bot pushed a commit that referenced this issue Dec 12, 2024
@seadanda @actions-user @bkchr
[pallet-broker] Fix auto renew benchmarks (#6505)
459b4a6 
Fix the broker pallet auto-renew benchmarks which have been broken since
#4424, yielding `Weightless` due to some prices being set too low, as
reported in #6474.

Upon further investigation it turned out that the auto-renew
contribution to `rotate_sale` was always failing but the error was
mapped. This is also fixed at the cost of a bit of setup overhead.

Fixes #6474

TODO:
- [x] Re-run weights

---------

Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: command-bot <>
Co-authored-by: Bastian Köcher <[email protected]>
seadanda added a commit that referenced this issue Dec 13, 2024
@seadanda
[pallet-broker] Fix auto renew benchmarks (#6505)
44be100 
Fix the broker pallet auto-renew benchmarks which have been broken since
reported in #6474.

Upon further investigation it turned out that the auto-renew
contribution to `rotate_sale` was always failing but the error was
mapped. This is also fixed at the cost of a bit of setup overhead.

Fixes #6474

TODO:
- [x] Re-run weights

---------

Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: command-bot <>
Co-authored-by: Bastian Köcher <[email protected]>
(cherry picked from commit 459b4a6)
seadanda added a commit that referenced this issue Dec 13, 2024
@seadanda
[pallet-broker] Fix auto renew benchmarks (#6505)
1071c05 
Fix the broker pallet auto-renew benchmarks which have been broken since
reported in #6474.

Upon further investigation it turned out that the auto-renew
contribution to `rotate_sale` was always failing but the error was
mapped. This is also fixed at the cost of a bit of setup overhead.

Fixes #6474

TODO:
- [x] Re-run weights

---------

Co-authored-by: GitHub Action <[email protected]>
Co-authored-by: command-bot <>
Co-authored-by: Bastian Köcher <[email protected]>
(cherry picked from commit 459b4a6)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
T12-benchmarks This PR/Issue is related to benchmarking and weights.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[pallet-broker] Fix auto renew benchmarks paritytech/polkadot-sdk
2 participants
@gui1117 @seadanda