Mitigate coretime auto-renew benchmarked weights issues #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pandres95 in case you haven't seen this |
pandres95
merged commit adc262e
into
pandres95:upgrade-polkadot-stable2409
1 check passed
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Auto-renew benchmarks are currently weightless due to some uncovered issues with the benchmarks reported in paritytech/polkadot-sdk#6474
This can be easily mitigated for
(enable|disable)_auto_renewby filtering the calls until the benchmarks have been fixed in paritytech/polkadot-sdk#6505 (or another way) and backported. However, this also affects start_sales so setting theMaxAutoRenewalsto 0 should negate its impact on the benchmark.Ideally we'd wait for this backport, but this simple change can be a short term fix if there is pressure to get this merged before then.