Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pallet-revive] eth-rpc add missing tests #6728

Merged
merged 11 commits into from
Dec 11, 2024
Merged

Conversation

pgherveou
Copy link
Contributor

@pgherveou pgherveou commented Dec 2, 2024

@pgherveou pgherveou marked this pull request as ready for review December 3, 2024 15:23
@pgherveou
Copy link
Contributor Author

/cmd prdoc --audience runtime_dev --bump minor

@pgherveou pgherveou added T7-smart_contracts This PR/Issue is related to smart contracts. R0-silent Changes should not be mentioned in any release notes labels Dec 3, 2024
Copy link
Member

@xermicus xermicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't we use the revive compiler JS package to get rid of the vendored fixtures?

@athei
Copy link
Member

athei commented Dec 10, 2024

Couldn't we use the revive compiler JS package to get rid of the vendored fixtures?

Yes I think this is the idea to do this eventually. But it will also require us to have node installed in the CI image. There are probably some dragons.

@pgherveou
Copy link
Contributor Author

/cmd prdoc --audience runtime_dev --bump minor

@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12263482350
Failed job name: test-linux-stable-runtime-benchmarks

@pgherveou pgherveou enabled auto-merge December 10, 2024 21:11
@pgherveou pgherveou added this pull request to the merge queue Dec 11, 2024
Merged via the queue into master with commit 99be9b1 Dec 11, 2024
198 of 199 checks passed
@pgherveou pgherveou deleted the pg/geth-diff-tests branch December 11, 2024 02:12
dudo50 pushed a commit to paraspell-research/polkadot-sdk that referenced this pull request Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes T7-smart_contracts This PR/Issue is related to smart contracts.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable rpc tests once we have recompiled the fixtures with a new revive
3 participants