[pallet-revive] eth-prc fix geth diff

[pgherveou]

• Add a bunch of differential tests to ensure that responses from eth-rpc matches the one from geth
  • These tests are not run in CI for now but can be run locally with

cd revive/rpc/examples/js
bun test

• EVM RPC server will not fail gas_estimation if no gas is specified, I updated pallet-revive to add an extra skip_transfer boolean check to replicate this behavior in our pallet

• eth_transact and bare_eth_transact api have been updated to use GenericTransaction directly as this is what is used by eth_estimateGas and eth_call

[pgherveou]

/cmd prdoc --audience runtime_dev --bump minor

[xermicus]

Just some nits

[xermicus]

Does the alloy crate or something similar provide those types?

[pgherveou]

Not sure, this is inspired by the go-ethereum source code

[pgherveou]

We don't depend on alloy, so not really worth adding a new dependency just for that for now

[paritytech-workflow-stopper]

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/12086529924
Failed job name: test-linux-stable

[athei]

I think you need to disable the tests written in Solidity for CI to pass. The 64bit PR broke them. Or you rebuilt them with a new revive.

[pgherveou]

I think you need to disable the tests written in Solidity for CI to pass. The 64bit PR broke them. Or you rebuilt them with a new revive.

Didn't you do it in your PR already?

[athei]

I think you need to disable the tests written in Solidity for CI to pass. The 64bit PR broke them. Or you rebuilt them with a new revive.

Didn't you do it in your PR already?

I did. I thought you added new tests here that need to be disabled. But the CI error is from something else.

[pgherveou]

Ah i was going to add a few tests will do that in a follow up

[cmichi]

@pgherveou I think you might have overlooked in fn bare_upload_code changing the

storage_deposit_limit: BalanceOf<T>,

to

storage_deposit_limit: DepositLimit<BalanceOf<T>>,

Here:
https://github.com/paritytech/polkadot-sdk/blob/master/substrate/frame/revive/src/lib.rs#L1468

[pgherveou]

@pgherveou I think you might have overlooked in fn bare_upload_code changing the

storage_deposit_limit: BalanceOf<T>,

to

storage_deposit_limit: DepositLimit<BalanceOf<T>>,

Here: https://github.com/paritytech/polkadot-sdk/blob/master/substrate/frame/revive/src/lib.rs#L1468

Thanks @cmichi, this new type barely acts as a more meaningful replacement for Option< DepositLimit<BalanceOf<T>>>
so we don't really need it here