-
Notifications
You must be signed in to change notification settings - Fork 709
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove stale extension version from UncheckedExtrinsic
v4 structure
#6404
Conversation
Signed-off-by: georgepisaltu <[email protected]>
bot bench-all substrate -v PIPELINE_SCRIPTS_REF=george/substrate-ext |
@georgepisaltu https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7719043 was started for your command Comment |
bot bench-all cumulus -v PIPELINE_SCRIPTS_REF=george/substrate-ext |
@georgepisaltu https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7719044 was started for your command Comment |
bot bench-all polkadot -v PIPELINE_SCRIPTS_REF=george/substrate-ext |
@georgepisaltu https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7719045 was started for your command Comment |
@georgepisaltu Command |
bot bench-all substrate -v PIPELINE_SCRIPTS_REF=george/substrate-ext |
@georgepisaltu https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7719176 was started for your command Comment |
@georgepisaltu Command |
bot bench-all substrate -v PIPELINE_SCRIPTS_REF=george/substrate-ext |
@georgepisaltu https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7719627 was started for your command Comment |
@georgepisaltu Command |
bot bench-all substrate -v PIPELINE_SCRIPTS_REF=george/substrate-ext |
@georgepisaltu https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/7719693 was started for your command Comment |
…ococo --target_dir=cumulus
@georgepisaltu Command |
…6380) This PR ensures that external addresses with different PeerIDs are not propagated to the higher layer of the network code. While at it, this ensures that libp2p only adds the `/p2p/peerid` part to the discovered address if it does not contain it already. This is a followup from: - #6298 cc @paritytech/networking --------- Signed-off-by: Alexandru Vasile <[email protected]> Co-authored-by: Dmitry Markin <[email protected]>
Fixes #5530 This PR introduces the removal of backing jobs that have been back pressured for longer than `allowedAncestryLen`, as these candidates are no longer viable. It is reasonable to expect a result for a backing job execution within `allowedAncestryLen` blocks. Therefore, we set the job TTL as a relay block number and synchronize the validation host by sending activated leaves. --------- Co-authored-by: Andrei Sandu <[email protected]> Co-authored-by: Branislav Kontur <[email protected]>
@georgepisaltu Command |
@@ -632,6 +632,7 @@ async fn request_candidate_validation( | |||
) -> Result<ValidationResult, Error> { | |||
let (tx, rx) = oneshot::channel(); | |||
let is_system = candidate_receipt.descriptor.para_id().is_system(); | |||
let relay_parent = candidate_receipt.descriptor.relay_parent(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why all these changes in backing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bot rebased or formatted the code. You can see my initial commit here, the rest of the changes are pushed by the bot.
…rget_dir=polkadot
@georgepisaltu Command |
UncheckedExtrinsic
v4 structureUncheckedExtrinsic
v4 structure
Signed-off-by: georgepisaltu <[email protected]>
Closing in favor of #6418 |
Follow up to #3685
The main PR introduced bare support for the new extension version byte. However, the extension version byte is not used for the old signed extrinsic type in version 4. This PR removes the byte from that structure, previously unused and defaulted to
0
.In this same PR, new weights will be generated for the modules affected by the main PR.