Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PVF: drop backing jobs if it is too late #5530

Closed
sandreim opened this issue Aug 30, 2024 · 0 comments · Fixed by #5616
Closed

PVF: drop backing jobs if it is too late #5530

sandreim opened this issue Aug 30, 2024 · 0 comments · Fixed by #5616
Assignees
Labels
I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task.

Comments

@sandreim
Copy link
Contributor

Related to #4632

If backing is being back pressured for longer than allowedAncestryLen, it is pointless to execute these jobs as the candidate is no longer viable.

We should pass a deadline timestamp for validation of backing jobs in the PVF host: deadline = now() + allowedAncestryLen * 6 - PvfExecTimeout. Before executing backing jobs we should check if we are past the deadline and drop them.

@sandreim sandreim added the I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task. label Aug 30, 2024
github-merge-queue bot pushed a commit that referenced this issue Nov 7, 2024
Fixes #5530

This PR introduces the removal of backing jobs that have been back
pressured for longer than `allowedAncestryLen`, as these candidates are
no longer viable.

It is reasonable to expect a result for a backing job execution within
`allowedAncestryLen` blocks. Therefore, we set the job TTL as a relay
block number and synchronize the validation host by sending activated
leaves.

---------

Co-authored-by: Andrei Sandu <[email protected]>
Co-authored-by: Branislav Kontur <[email protected]>
@github-project-automation github-project-automation bot moved this from Backlog to Completed in parachains team board Nov 7, 2024
paritytech-ci pushed a commit that referenced this issue Nov 7, 2024
Fixes #5530

This PR introduces the removal of backing jobs that have been back
pressured for longer than `allowedAncestryLen`, as these candidates are
no longer viable.

It is reasonable to expect a result for a backing job execution within
`allowedAncestryLen` blocks. Therefore, we set the job TTL as a relay
block number and synchronize the validation host by sending activated
leaves.

---------

Co-authored-by: Andrei Sandu <[email protected]>
Co-authored-by: Branislav Kontur <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I9-optimisation An enhancement to provide better overall performance in terms of time-to-completion for a task.
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

2 participants