-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix storage expansion in pallet section #6023
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkchr
reviewed
Oct 11, 2024
substrate/frame/support/procedural/src/pallet/expand/storage.rs
Outdated
Show resolved
Hide resolved
For the added test, without the fix:
|
gui1117
approved these changes
Oct 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm surprise the code didn't compile.
New code is good, so it is good to me.
gui1117
added
the
T1-FRAME
This PR/Issue is related to core FRAME, the framework.
label
Oct 12, 2024
bkchr
approved these changes
Oct 12, 2024
Zebedeusz
pushed a commit
that referenced
this pull request
Oct 14, 2024
fixes #5320 @sam0x17 @gupnik # Description The issue could be confirmed with the added example. The cause is for macro hygiene, `entries` in the `#( #entries_builder )*` expansion won't be able to reference the `entries` defined outside. The solution here is to allow the reference to be passed into the expansion with closure. Or we could just switch to the unhygienic span with `quote::quote!` instead such that `entries` will resolve to the "outer" definition.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5320 @sam0x17 @gupnik
Description
The issue could be confirmed with the added example. The cause is for macro hygiene,
entries
in the#( #entries_builder )*
expansion won't be able to reference theentries
defined outside. The solution here is to allow the reference to be passed into the expansion with closure.Or we could just switch to the unhygienic span with
quote::quote!
instead such thatentries
will resolve to the "outer" definition.