/cmd: Improved devx of benching many pallets simultaneously #6007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mordamax
changed the title
mordamax
added
the
R0-silent
alvicsam
approved these changes
Oct 11, 2024
mordamax
changed the title
ggwpez
approved these changes
Oct 11, 2024
kianenigma
reviewed
Oct 11, 2024
| @@ -19,51 +19,53 @@ In a PR run the actions through comment: | |||
|
|
|||
| To regenerate all weights (however it will take long, | |||
| so don't do it unless you really need it), run the following command: | |||
|
|
|||
There was a problem hiding this comment.
This is a great doc, is it properly linked and discover-able from the main CONTRIBUTING.md?
There was a problem hiding this comment.
yep, there is a general link to /cmd commands-readme and from there to here
kianenigma
approved these changes
Oct 11, 2024
Zebedeusz
pushed a commit
that referenced
this pull request
Oct 14, 2024
### Improved devx of running many pallets simultaneously Changes to /cmd: - Replace (flip) `--continue-on-fail` with `--fail-fast`, but only for `bench`. This makes all pallets/runtimes run non-stop by default, as it was primary use-case during tests - The list of successful/failed pallets was hard to find within tons of logs, so decided to write only needed logs in a file, and output as a summary in the workflow and in the comment - Side fix: updated `tasks_example` to `pallet_example_tasks` to make compliant with standard naming <img width="1006" alt="image" src="https://github.com/user-attachments/assets/14896041-7018-4a0d-92b7-4508e81913c2"> + added command results to workflow summary: <img width="1275" alt="image" src="https://github.com/user-attachments/assets/b4a8afdb-dc9f-4ff9-9720-28a88956035f"> --------- Co-authored-by: GitHub Action <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved devx of running many pallets simultaneously
Changes to /cmd:
--continue-on-failwith--fail-fast, but only forbench. This makes all pallets/runtimes run non-stop by default, as it was primary use-case during teststasks_exampletopallet_example_tasksto make compliant with standard naming