Bump authoring duration for async backing to 2s. #5195
Conversation
| @@ -185,7 +185,7 @@ | |||
| //! client.code_at(block_hash).ok().map(|c| ValidationCode::from(c).hash()) | |||
| //! }, | |||
| //! .. | |||
| //! authoring_duration: Duration::from_millis(1500), | |||
There was a problem hiding this comment.
I think this one needs to be increased as well: https://github.com/paritytech/polkadot-sdk/blob/master/cumulus/polkadot-parachain/src/service.rs#L835
Right @s0me0ne-unkn0wn ?
There was a problem hiding this comment.
Westend still has 2sec backing timeout, so we should bump it on Westend first, and then we may bump it there.
It also should be considered that this change would affect all the system parachains as they're using polkadot-parachain to run collators, so, although it should be safe to bump it, I'd try it on our collators first, just in case.
There was a problem hiding this comment.
I think it should be fine, AFAIK nobody is actually fully saturating the execution.
There was a problem hiding this comment.
Well, some runtimes do saturate by design (like HydraDX) so they may start having problems on Westend. On the other hand, I doubt if they're using polkadot-parachain to collate 🤔
Overall, yes, should be totally fine, but one cannot be too paranoid with a change affecting system parachains 🙂
| @@ -185,7 +185,7 @@ | |||
| //! client.code_at(block_hash).ok().map(|c| ValidationCode::from(c).hash()) | |||
| //! }, | |||
| //! .. | |||
| //! authoring_duration: Duration::from_millis(1500), | |||
There was a problem hiding this comment.
I think it should be fine, AFAIK nobody is actually fully saturating the execution.
| @@ -174,7 +174,7 @@ | |||
| //! - In the `para_client` field, pass in a cloned para client rather than the original | |||
| //! - Add a `para_backend` parameter after `para_client`, passing in our para backend | |||
| //! - Provide a `code_hash_provider` closure like that shown below | |||
| //! - Increase `authoring_duration` from 500 milliseconds to 1500 | |||
| //! - Increase `authoring_duration` from 500 milliseconds to 2000 | |||
There was a problem hiding this comment.
I would make it clear how this value is related to the configuration on the relay chain.
|
Hi! thank you very much for reporting this. We have already applied this change in our internal test instance and we will be doing in Paseo very soon. |
|
The executor params are now set on westend |
|
Hi! The executor params were also applied in Paseo. |
* master: (35 commits) Fix OurViewChange small race (#5356) Make ticket non-optional and add ensure_successful method to Consideration trait (#5359) [tests] dedup test code, add more tests, improve naming and docs (#5338) Stop running the wishlist workflow on forks (#5297) Migrate foreign assets v3::Location to v4::Location (#4129) Minor clean up (#5284) [Pools] Ensure members can always exit the pool gracefully (#4998) StorageWeightReclaim: set to node pov size if higher (#5281) [Bot] Add prdoc generation (#5331) Small nits found accidentally along the way (#5341) Create subsystem-benchmarks.yml (#5325) Bump libp2p-identity from 0.2.8 to 0.2.9 (#5232) Bump authoring duration for async backing to 2s. (#5195) Fix spelling issues (#5206) Bump the known_good_semver group across 1 directory with 3 updates (#5315) `polkadot-node-core-pvf-common`: Fix test compilation error (#5310) ci: Paused `cmd-action` commenter (#5287) Remove unnecessary mut (#5318) chain-spec: minor clarification on the genesis config patch (#5324) fix av-distribution Jaeger spans mem leak (#5321) ...
* master: (35 commits) Fix OurViewChange small race (#5356) Make ticket non-optional and add ensure_successful method to Consideration trait (#5359) [tests] dedup test code, add more tests, improve naming and docs (#5338) Stop running the wishlist workflow on forks (#5297) Migrate foreign assets v3::Location to v4::Location (#4129) Minor clean up (#5284) [Pools] Ensure members can always exit the pool gracefully (#4998) StorageWeightReclaim: set to node pov size if higher (#5281) [Bot] Add prdoc generation (#5331) Small nits found accidentally along the way (#5341) Create subsystem-benchmarks.yml (#5325) Bump libp2p-identity from 0.2.8 to 0.2.9 (#5232) Bump authoring duration for async backing to 2s. (#5195) Fix spelling issues (#5206) Bump the known_good_semver group across 1 directory with 3 updates (#5315) `polkadot-node-core-pvf-common`: Fix test compilation error (#5310) ci: Paused `cmd-action` commenter (#5287) Remove unnecessary mut (#5318) chain-spec: minor clarification on the genesis config patch (#5324) fix av-distribution Jaeger spans mem leak (#5321) ...
* master: (167 commits) Upgrade accidentally downgraded deps (#5365) [Pools] Fix issues with member migration to `DelegateStake` (#4822) Unify `no_genesis` check (#5360) [CI] Fix prdoc command (#5358) Beefy: add benchmarks for `report_fork_voting()` (#5188) Fix OurViewChange small race (#5356) Make ticket non-optional and add ensure_successful method to Consideration trait (#5359) [tests] dedup test code, add more tests, improve naming and docs (#5338) Stop running the wishlist workflow on forks (#5297) Migrate foreign assets v3::Location to v4::Location (#4129) Minor clean up (#5284) [Pools] Ensure members can always exit the pool gracefully (#4998) StorageWeightReclaim: set to node pov size if higher (#5281) [Bot] Add prdoc generation (#5331) Small nits found accidentally along the way (#5341) Create subsystem-benchmarks.yml (#5325) Bump libp2p-identity from 0.2.8 to 0.2.9 (#5232) Bump authoring duration for async backing to 2s. (#5195) Fix spelling issues (#5206) Bump the known_good_semver group across 1 directory with 3 updates (#5315) ...
Should be safe on all production network.
I noticed that Paseo needs to be updated, it is lacking behind in a couple of things.
Execution environment parameters should be updated to those of Polkadot: