Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Pools] Ensure members can always exit the pool gracefully #4998

Merged
merged 27 commits into from
Aug 13, 2024
Merged

[Pools] Ensure members can always exit the pool gracefully #4998

merged 27 commits into from
Aug 13, 2024

Conversation

Ank4n
Copy link
Contributor

@Ank4n Ank4n commented Jul 11, 2024 •
edited
Loading

Changes

  • Clear any dangling delegation when member is removed.
  • Agents need to be killed explicitly when pools are destroyed.
  • Member withdraw amount is max of their locked funds and the value of their points.

@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable 2/3
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6682947

@Ank4n Ank4n changed the title Only withdraw upto total delegated [Pools] Ensure members can be removed even if pool cannot release all their funds Jul 12, 2024
@Ank4n Ank4n added the T2-pallets This PR/Issue is related to a particular pallet. label Jul 13, 2024
@Ank4n Ank4n marked this pull request as ready for review July 13, 2024 00:16
@Ank4n Ank4n requested a review from a team as a code owner July 13, 2024 00:16
@Ank4n Ank4n requested a review from gpestana July 13, 2024 00:17
@Ank4n Ank4n changed the title [Pools] Ensure members can be removed even if pool cannot release all their funds [Pools] Ensure members can always exit the pool gracefully Jul 13, 2024
@Ank4n Ank4n requested a review from kianenigma July 13, 2024 09:54
@Ank4n Ank4n self-assigned this Aug 7, 2024
gpestana
gpestana approved these changes Aug 13, 2024
View reviewed changes
substrate/frame/delegated-staking/src/lib.rs Outdated Show resolved Hide resolved
substrate/frame/nomination-pools/src/lib.rs Outdated Show resolved Hide resolved
@Ank4n Ank4n enabled auto-merge August 13, 2024 15:08
@Ank4n
Copy link
Contributor Author

Ank4n commented Aug 13, 2024

bot fmt

@command-bot
Copy link

command-bot bot commented Aug 13, 2024 •
edited
Loading

@Ank4n https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6997203 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 13-215d45c8-1461-4934-b9ae-3bff0051c946 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Aug 13, 2024

@Ank4n Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6997203 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/6997203/artifacts/download.

@Ank4n Ank4n added this pull request to the merge queue Aug 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 13, 2024
@Ank4n Ank4n enabled auto-merge August 13, 2024 20:55
@Ank4n Ank4n added this pull request to the merge queue Aug 13, 2024
Merged via the queue into master with commit 42eb4ec Aug 13, 2024
173 of 174 checks passed
@Ank4n Ank4n deleted the ankan/delegation-release-best-effort branch August 13, 2024 22:34
ordian added a commit that referenced this pull request Aug 14, 2024
@ordian
Merge branch 'master' into ao-enact-candidate-weight
ef78697 
* master: (35 commits)
  Fix OurViewChange small race (#5356)
  Make ticket non-optional and add ensure_successful method to Consideration trait (#5359)
  [tests] dedup test code, add more tests, improve naming and docs (#5338)
  Stop running the wishlist workflow on forks (#5297)
  Migrate foreign assets v3::Location to v4::Location (#4129)
  Minor clean up (#5284)
  [Pools] Ensure members can always exit the pool gracefully (#4998)
  StorageWeightReclaim: set to node pov size if higher (#5281)
  [Bot] Add prdoc generation (#5331)
  Small nits found accidentally along the way (#5341)
  Create subsystem-benchmarks.yml (#5325)
  Bump libp2p-identity from 0.2.8 to 0.2.9 (#5232)
  Bump authoring duration for async backing to 2s. (#5195)
  Fix spelling issues (#5206)
  Bump the known_good_semver group across 1 directory with 3 updates (#5315)
  `polkadot-node-core-pvf-common`: Fix test compilation error (#5310)
  ci: Paused `cmd-action` commenter (#5287)
  Remove unnecessary mut (#5318)
  chain-spec: minor clarification on the genesis config patch (#5324)
  fix av-distribution Jaeger spans mem leak (#5321)
  ...
ordian added a commit that referenced this pull request Aug 14, 2024
@ordian
Merge branch 'master' into ao-fix-parainclusion-weight-overestimation
cbe0b3f 
* master: (35 commits)
  Fix OurViewChange small race (#5356)
  Make ticket non-optional and add ensure_successful method to Consideration trait (#5359)
  [tests] dedup test code, add more tests, improve naming and docs (#5338)
  Stop running the wishlist workflow on forks (#5297)
  Migrate foreign assets v3::Location to v4::Location (#4129)
  Minor clean up (#5284)
  [Pools] Ensure members can always exit the pool gracefully (#4998)
  StorageWeightReclaim: set to node pov size if higher (#5281)
  [Bot] Add prdoc generation (#5331)
  Small nits found accidentally along the way (#5341)
  Create subsystem-benchmarks.yml (#5325)
  Bump libp2p-identity from 0.2.8 to 0.2.9 (#5232)
  Bump authoring duration for async backing to 2s. (#5195)
  Fix spelling issues (#5206)
  Bump the known_good_semver group across 1 directory with 3 updates (#5315)
  `polkadot-node-core-pvf-common`: Fix test compilation error (#5310)
  ci: Paused `cmd-action` commenter (#5287)
  Remove unnecessary mut (#5318)
  chain-spec: minor clarification on the genesis config patch (#5324)
  fix av-distribution Jaeger spans mem leak (#5321)
  ...
ordian added a commit that referenced this pull request Aug 15, 2024
@ordian
Merge branch 'master' into ao-fix-backing-filtering-on-disputes
55f5782 
* master: (167 commits)
  Upgrade accidentally downgraded deps (#5365)
  [Pools] Fix issues with member migration to `DelegateStake` (#4822)
  Unify `no_genesis` check (#5360)
  [CI] Fix prdoc command (#5358)
  Beefy: add benchmarks for `report_fork_voting()` (#5188)
  Fix OurViewChange small race (#5356)
  Make ticket non-optional and add ensure_successful method to Consideration trait (#5359)
  [tests] dedup test code, add more tests, improve naming and docs (#5338)
  Stop running the wishlist workflow on forks (#5297)
  Migrate foreign assets v3::Location to v4::Location (#4129)
  Minor clean up (#5284)
  [Pools] Ensure members can always exit the pool gracefully (#4998)
  StorageWeightReclaim: set to node pov size if higher (#5281)
  [Bot] Add prdoc generation (#5331)
  Small nits found accidentally along the way (#5341)
  Create subsystem-benchmarks.yml (#5325)
  Bump libp2p-identity from 0.2.8 to 0.2.9 (#5232)
  Bump authoring duration for async backing to 2s. (#5195)
  Fix spelling issues (#5206)
  Bump the known_good_semver group across 1 directory with 3 updates (#5315)
  ...
@ggwpez ggwpez mentioned this pull request Sep 9, 2024
Closed
@github-actions github-actions bot mentioned this pull request Oct 8, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kianenigma kianenigma kianenigma approved these changes

@gpestana gpestana gpestana approved these changes

Assignees

@Ank4n Ank4n

Labels
T2-pallets This PR/Issue is related to a particular pallet.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ank4n @paritytech-cicd-pr @gpestana @kianenigma