Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting Started Script #4879

Merged
merged 13 commits into from
Jul 25, 2024
Merged

Conversation

apopiak
Copy link
Contributor

@apopiak apopiak commented Jun 25, 2024

closes #4879

Provide a fast and easy way for people to get started developing with Polkadot SDK.

Sets up a development environment (including Rust) and clones and builds the minimal template.

Polkadot address: 16xyKzix34WZ4um8C3xzMdjKhrAQe9DjCf4KxuHsmTjdcEd

scripts/getting-started.sh Outdated Show resolved Hide resolved
scripts/getting-started.sh Outdated Show resolved Hide resolved
else
if prompt "\n🍺 Homebrew is not installed. Install it?"; then
echo "🍺 Installing Homebrew."
/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install.sh)"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think wget is default installed on Debian, but not curl. Maybe do a sanity check at the top that all the requirements are there with a nice error message otherwise?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is installing homebrew, though? It's on MacOS

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is also further down used. I just tried this in a docker and got the error that wget was not found.

scripts/getting-started.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@kianenigma kianenigma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All in all looks good!

Can you also please add a 1 liner that downloads this file with curl from raw.githubusercontent.... and pipes it to bash or similar?

And, please provide your DOT address in the PR description for a tp if you wish so :)

@apopiak
Copy link
Contributor Author

apopiak commented Jul 11, 2024

Can you also please add a 1 liner that downloads this file with curl from raw.githubusercontent.... and pipes it to bash or similar?

Mmmh, bit of a chicken and egg problem, no? Don't want to reference my personal repo, but the polkadot-sdk one isn't live yet?

curl --proto '=https' --tlsv1.2 -sSf https://raw.githubusercontent.com/apopiak/polkadot-sdk/apopiak/getting-started/scripts/getting-started.sh | sh

Should do the trick to try it out, though for me the prompting seems to no quite work correctly somehow? (it defaults to enter/yes?)

Edit: Added what I would expect the URL to be after the merge.

And, please provide your DOT address in the PR description for a tp if you wish so :)

🙏
16xyKzix34WZ4um8C3xzMdjKhrAQe9DjCf4KxuHsmTjdcEd

@apopiak
Copy link
Contributor Author

apopiak commented Jul 11, 2024

Sorry y'all for the slow response to your comments.
Feel free to merge and/or adjust. Will unfortunately be offline from tomorrow until the 24th.

@kianenigma
Copy link
Contributor

/tip medium

@kianenigma kianenigma requested review from ggwpez, bkchr and skunert July 25, 2024 11:28
Copy link

@kianenigma A referendum for a medium (80 DOT) tip was successfully submitted for @apopiak (16xyKzix34WZ4um8C3xzMdjKhrAQe9DjCf4KxuHsmTjdcEd on polkadot).

Referendum number: 1031.
tip

@kianenigma kianenigma added the R0-silent Changes should not be mentioned in any release notes label Jul 25, 2024
Copy link

The referendum has appeared on Polkassembly.

Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay lets just merge this first version and then iterate.
Would also like to have a CI check with a docker Debian container to verify that it works.

We had such a script in the past and it did not have any checks, so it became unusable swiftly.

@ggwpez ggwpez enabled auto-merge July 25, 2024 12:55
@ggwpez ggwpez added this pull request to the merge queue Jul 25, 2024
Merged via the queue into paritytech:master with commit 8c61dba Jul 25, 2024
155 of 159 checks passed
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this pull request Aug 2, 2024
closes paritytech#4879

Provide a fast and easy way for people to get started developing with
Polkadot SDK.

Sets up a development environment (including Rust) and clones and builds
the minimal template.

Polkadot address: 16xyKzix34WZ4um8C3xzMdjKhrAQe9DjCf4KxuHsmTjdcEd

---------

Co-authored-by: Kian Paimani <[email protected]>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants