-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Getting Started Script #4879
Getting Started Script #4879
Conversation
else | ||
if prompt "\n🍺 Homebrew is not installed. Install it?"; then | ||
echo "🍺 Installing Homebrew." | ||
/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install.sh)" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think wget is default installed on Debian, but not curl. Maybe do a sanity check at the top that all the requirements are there with a nice error message otherwise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is installing homebrew, though? It's on MacOS
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is also further down used. I just tried this in a docker and got the error that wget
was not found.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All in all looks good!
Can you also please add a 1 liner that downloads this file with curl
from raw.githubusercontent....
and pipes it to bash
or similar?
And, please provide your DOT address in the PR description for a tp if you wish so :)
Mmmh, bit of a chicken and egg problem, no? Don't want to reference my personal repo, but the polkadot-sdk one isn't live yet?
Should do the trick to try it out, though for me the prompting seems to no quite work correctly somehow? (it defaults to enter/yes?) Edit: Added what I would expect the URL to be after the merge.
🙏 |
Sorry y'all for the slow response to your comments. |
/tip medium |
@kianenigma A referendum for a medium (80 DOT) tip was successfully submitted for @apopiak (16xyKzix34WZ4um8C3xzMdjKhrAQe9DjCf4KxuHsmTjdcEd on polkadot). |
The referendum has appeared on Polkassembly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay lets just merge this first version and then iterate.
Would also like to have a CI check with a docker Debian container to verify that it works.
We had such a script in the past and it did not have any checks, so it became unusable swiftly.
8c61dba
closes paritytech#4879 Provide a fast and easy way for people to get started developing with Polkadot SDK. Sets up a development environment (including Rust) and clones and builds the minimal template. Polkadot address: 16xyKzix34WZ4um8C3xzMdjKhrAQe9DjCf4KxuHsmTjdcEd --------- Co-authored-by: Kian Paimani <[email protected]> Co-authored-by: Oliver Tale-Yazdi <[email protected]>
closes #4879
Provide a fast and easy way for people to get started developing with Polkadot SDK.
Sets up a development environment (including Rust) and clones and builds the minimal template.
Polkadot address: 16xyKzix34WZ4um8C3xzMdjKhrAQe9DjCf4KxuHsmTjdcEd