Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Check for getting-started script #5144

Closed
ggwpez opened this issue Jul 25, 2024 · 2 comments
Closed

[CI] Check for getting-started script #5144

ggwpez opened this issue Jul 25, 2024 · 2 comments

Comments

@ggwpez
Copy link
Member

ggwpez commented Jul 25, 2024 •
edited
Loading

The getting-started script should have a check in a Debian docker container (at least) to ensure that it wont completely break.
MacOs docker would also be nice, if possible. We dont need to run this every time, just every week or so is fine.

@apopiak are you interested in adding this maybe?
@kianenigma
Copy link
Contributor

To begin with, curl --proto '=https' --tlsv1.2 -sSf https://raw.githubusercontent.com/paritytech/polkadot-sdk/master/scripts/getting-started.sh is missing a | bash :D

kianenigma added a commit that referenced this issue Jul 26, 2024
@kianenigma
Update README.md
fd945c6 
Related to #5144, plus remove the lines of code badge as it was not working.
@kianenigma kianenigma mentioned this issue Jul 26, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 26, 2024
@kianenigma
Update README.md (#5152)
7e4433e 
Related to #5144, plus
remove the lines of code badge as it was not working.
TarekkMA pushed a commit to moonbeam-foundation/polkadot-sdk that referenced this issue Aug 2, 2024
@kianenigma @TarekkMA
Update README.md (paritytech#5152)
c392fc4 
Related to paritytech#5144, plus
remove the lines of code badge as it was not working.
@ggwpez
Copy link
Member Author

ggwpez commented Oct 25, 2024

We have CI checks for this now here https://github.com/paritytech/polkadot-sdk/blob/master/.github/workflows/check-getting-started.yml

@ggwpez ggwpez closed this as completed Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kianenigma @ggwpez