Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport XCM fixes to 1.4.0 #3173

Merged
merged 18 commits into from
Feb 14, 2024
Merged

Backport XCM fixes to 1.4.0 #3173

merged 18 commits into from
Feb 14, 2024

Conversation

franciscoaguirre
Copy link
Contributor

@franciscoaguirre franciscoaguirre commented Feb 1, 2024 •
edited
Loading

Backporting xcm fixes to 1.4.0:

  • Transactional processing
  • Delivery fee taken from holding

@franciscoaguirre franciscoaguirre requested review from andresilva and a team as code owners February 1, 2024 15:37
@franciscoaguirre franciscoaguirre added R0-silent Changes should not be mentioned in any release notes T6-XCM This PR/Issue is related to XCM. labels Feb 1, 2024
@franciscoaguirre
Copy link
Contributor Author

bot fmt

@command-bot
Copy link

command-bot bot commented Feb 1, 2024 •
edited
Loading

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5099144 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-f8f2959d-6c93-4114-87a0-da2b5fe27e0b to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Feb 1, 2024

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5099144 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5099144/artifacts/download.

@franciscoaguirre franciscoaguirre changed the title Xcm backports to 1.4.0 Backport XCM fixes to 1.4.0 Feb 1, 2024
@franciscoaguirre
Copy link
Contributor Author

bot fmt

@command-bot
Copy link

command-bot bot commented Feb 2, 2024 •
edited
Loading

@franciscoaguirre https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5106522 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-fa885034-1b93-4570-a006-b1d34d0a6c63 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Feb 2, 2024

@franciscoaguirre Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5106522 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5106522/artifacts/download.

franciscoaguirre and others added 6 commits February 2, 2024 13:27
@franciscoaguirre
Add missing TransactionalProcessor entries
2edef6d
@franciscoaguirre
Fixes
b1d3d18
@franciscoaguirre
Fixes
8fbb7aa
@franciscoaguirre
Fix unused imports
678a372
@franciscoaguirre
Add a missing implementation
827cc41
@bkontur @franciscoaguirre
[ci] Add -D warnings for cargo-check-each-crate job to fail on wa…
2d8ae50 
…rnings (#2670)

This PR turns on `-D warnings` for `cargo-check-each-crate job` job to
fail on warnings e.g. like this:
https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4673130

Before this PR, there was a warning and `cargo-check-each-crate` job did
not fail:
https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4641444
```
warning: unused import: `ToTokens`
  --> substrate/primitives/api/proc-macro/src/utils.rs:22:34
   |
22 | use quote::{format_ident, quote, ToTokens};
   |                                  ^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default
warning: `sp-api-proc-macro` (lib) generated 1 warning (run `cargo fix --lib -p sp-api-proc-macro` to apply 1 suggestion)
```

Fixes on the way:
https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4641444
https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4673265
https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4673410
https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4673681
https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4673836
https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4673941
https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4674256
https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4679328

- [ ] why does this check triggers only `cargo check --locked`?
`--all-features` or `--all-targets` are not needed? Or aren't they
avoided intentionally?

---------

Co-authored-by: command-bot <>
@franciscoaguirre franciscoaguirre requested a review from a team as a code owner February 2, 2024 15:39
franciscoaguirre and others added 2 commits February 2, 2024 17:28
@franciscoaguirre
Fixes
327c880
@alvicsam @ggwpez
@bkchr @liamaharon @seadanda @rcny @franciscoaguirre
[ci] Update rust in ci image (1.75 and 2024-01-22) (#3016)
aedbd8e 
cc paritytech/ci_cd#926

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: command-bot <>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Liam Aharon <[email protected]>
Co-authored-by: Dónal Murray <[email protected]>
Co-authored-by: Vladimir Istyufeev <[email protected]>
@franciscoaguirre franciscoaguirre requested review from a team as code owners February 5, 2024 12:05
@paritytech-review-bot paritytech-review-bot bot requested a review from a team February 5, 2024 12:06
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: test-linux-stable-int
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5128963

@KiChjang
Copy link
Contributor

bot fmt

@command-bot
Copy link

command-bot bot commented Feb 14, 2024 •
edited
Loading

@KiChjang https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5208919 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-c051d770-b2e6-4ff3-9eb7-bc0047100a74 to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Feb 14, 2024

@KiChjang Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5208919 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5208919/artifacts/download.

@acatangiu acatangiu merged commit 434d07d into release-crates-io-v1.4.0 Feb 14, 2024
105 of 115 checks passed
@acatangiu acatangiu deleted the xcm-backports branch February 14, 2024 09:28
@franciscoaguirre franciscoaguirre mentioned this pull request Feb 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acatangiu acatangiu acatangiu approved these changes

@KiChjang KiChjang KiChjang approved these changes

@andresilva andresilva Awaiting requested review from andresilva

@athei athei Awaiting requested review from athei athei is a code owner

Assignees
No one assigned
Labels
R0-silent Changes should not be mentioned in any release notes T6-XCM This PR/Issue is related to XCM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@franciscoaguirre @paritytech-cicd-pr @KiChjang @acatangiu @bkontur @alvicsam @rcny