Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ci] Update rust in ci image (1.75 and 2024-01-22) #3016

Merged
merged 24 commits into from
Jan 30, 2024
Merged

[ci] Update rust in ci image (1.75 and 2024-01-22) #3016

merged 24 commits into from
Jan 30, 2024

Conversation

alvicsam
Copy link
Contributor

@alvicsam alvicsam requested a review from a team as a code owner January 22, 2024 12:29
@alvicsam alvicsam requested a review from a team as a code owner January 22, 2024 12:31
@alvicsam alvicsam added A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). R0-silent Changes should not be mentioned in any release notes labels Jan 22, 2024
@alvicsam alvicsam requested a review from athei as a code owner January 22, 2024 12:57
@alvicsam alvicsam requested a review from a team January 22, 2024 12:57
@alvicsam alvicsam requested a review from a team January 22, 2024 13:00
@alvicsam
Copy link
Contributor Author

bot help

@command-bot
Copy link

command-bot bot commented Jan 22, 2024

Here's a link to docs

@alvicsam
Copy link
Contributor Author

bot fmt -v CMD_IMAGE=paritytech/ci-unified:bullseye-1.75.0-2024-01-22-v20240109

@command-bot
Copy link

command-bot bot commented Jan 22, 2024 •
edited
Loading

@alvicsam https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4993303 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh". Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 1-eef4715d-dc5a-4408-93df-70c987407c7b to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jan 22, 2024

@alvicsam Command "$PIPELINE_SCRIPTS_DIR/commands/fmt/fmt.sh" has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4993303 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4993303/artifacts/download.

ggwpez
ggwpez approved these changes Jan 22, 2024
View reviewed changes
Copy link
Member

@ggwpez ggwpez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

substrate/frame/contracts/fixtures/build.rs Outdated Show resolved Hide resolved
@paritytech-review-bot paritytech-review-bot bot requested a review from a team January 23, 2024 12:28
@alvicsam
Copy link
Contributor Author

bot update-ui latest --rust_version=1.75

@command-bot
Copy link

command-bot bot commented Jan 23, 2024 •
edited
Loading

@alvicsam https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5006699 was started for your command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" --rust_version=1.75. Check out https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/pipelines?page=1&scope=all&username=group_605_bot to know what else is being executed currently.

Comment bot cancel 2-81ba27d5-c4ee-48e9-935a-346e55eb343b to cancel this command or bot cancel to cancel all commands in this pull request.

@command-bot
Copy link

command-bot bot commented Jan 23, 2024

@alvicsam Command "$PIPELINE_SCRIPTS_DIR/commands/update-ui/update-ui.sh" --rust_version=1.75 has finished. Result: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5006699 has finished. If any artifacts were generated, you can download them from https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/5006699/artifacts/download.

liamaharon
liamaharon approved these changes Jan 24, 2024
View reviewed changes
.gitlab-ci.yml Show resolved Hide resolved
@alvicsam
Copy link
Contributor Author

Could someone from @paritytech/bridges-core approve this PR plz?

@alvicsam alvicsam enabled auto-merge January 24, 2024 11:51
@alvicsam alvicsam disabled auto-merge January 24, 2024 15:35
@ggwpez ggwpez added this pull request to the merge queue Jan 26, 2024
@mordamax
Copy link
Contributor

mordamax commented Jan 26, 2024 •
edited
Loading

bot update-ui latest --rust_version=1.75

@alvicsam didn't you have to pass/override the new image same as you did with fmt?

it failed but the image you have run it against was paritytech/ci-unified:bullseye-1.74.0-2023-11-01-v20240108

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 26, 2024
@seadanda seadanda added this pull request to the merge queue Jan 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 30, 2024
@ggwpez ggwpez added this pull request to the merge queue Jan 30, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 30, 2024
@rcny
Copy link
Contributor

rcny commented Jan 30, 2024

What is the preferred solution when Clippy complains about unused imports? Just remove them or add #[allow(unused_imports)]? I removed them, but I noticed the second approach in the code.

@bkchr
Copy link
Member

bkchr commented Jan 30, 2024

For the tests the unused_imports is fine.

@ggwpez ggwpez added this pull request to the merge queue Jan 30, 2024
Merged via the queue into master with commit 5b7f24f Jan 30, 2024
121 checks passed
@ggwpez ggwpez deleted the as-ci-upd branch January 30, 2024 23:58
franciscoaguirre pushed a commit that referenced this pull request Feb 5, 2024
@alvicsam @ggwpez
@bkchr @liamaharon @seadanda @rcny @franciscoaguirre
[ci] Update rust in ci image (1.75 and 2024-01-22) (#3016)
a455c80 
cc paritytech/ci_cd#926

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: command-bot <>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Liam Aharon <[email protected]>
Co-authored-by: Dónal Murray <[email protected]>
Co-authored-by: Vladimir Istyufeev <[email protected]>
franciscoaguirre pushed a commit that referenced this pull request Feb 5, 2024
@alvicsam @ggwpez
@bkchr @liamaharon @seadanda @rcny @franciscoaguirre
[ci] Update rust in ci image (1.75 and 2024-01-22) (#3016)
aedbd8e 
cc paritytech/ci_cd#926

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: command-bot <>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Liam Aharon <[email protected]>
Co-authored-by: Dónal Murray <[email protected]>
Co-authored-by: Vladimir Istyufeev <[email protected]>
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
@alvicsam @ggwpez
@bkchr @liamaharon @seadanda @rcny
[ci] Update rust in ci image (1.75 and 2024-01-22) (paritytech#3016)
e9d632a 
cc paritytech/ci_cd#926

---------

Signed-off-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: command-bot <>
Co-authored-by: Oliver Tale-Yazdi <[email protected]>
Co-authored-by: Bastian Köcher <[email protected]>
Co-authored-by: Liam Aharon <[email protected]>
Co-authored-by: Dónal Murray <[email protected]>
Co-authored-by: Vladimir Istyufeev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggwpez ggwpez ggwpez approved these changes

@bkchr bkchr bkchr left review comments

@sergejparity sergejparity sergejparity approved these changes

@acatangiu acatangiu acatangiu approved these changes

@serban300 serban300 serban300 approved these changes

@liamaharon liamaharon liamaharon approved these changes

@seadanda seadanda seadanda approved these changes

@bkontur bkontur bkontur approved these changes

@EgorPopelyaev EgorPopelyaev EgorPopelyaev approved these changes

@athei athei athei approved these changes

@svyatonik svyatonik svyatonik approved these changes

Assignees
No one assigned
Labels
A1-insubstantial Pull request requires no code review (e.g., a sub-repository hash update). R0-silent Changes should not be mentioned in any release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.