Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parachain-system: Send same event & digest as a standalone chain #2064

Merged
merged 3 commits into from
Oct 30, 2023

Conversation

bkchr
Copy link
Member

@bkchr bkchr commented Oct 27, 2023

This ensures that upgrading a parachain code sends the same event & digest as when using set_code on a standalone chain.

Close: #2049

This ensures that upgrading a parachain code sends the same event &
digest as when using `set_code` on a standalone chain.
@bkchr bkchr added the T1-FRAME This PR/Issue is related to core FRAME, the framework. label Oct 27, 2023
@bkchr bkchr requested review from a team October 27, 2023 16:06
@paritytech-cicd-pr
Copy link

The CI pipeline was cancelled due to failure one of the required jobs.
Job name: cargo-clippy
Logs: https://gitlab.parity.io/parity/mirrors/polkadot-sdk/-/jobs/4110066

@bkchr bkchr enabled auto-merge (squash) October 30, 2023 16:21
@bkchr bkchr merged commit 2d9426f into master Oct 30, 2023
111 of 114 checks passed
@bkchr bkchr deleted the bkchr-parachain-code-upgrade-same-events branch October 30, 2023 16:37
bgallois pushed a commit to duniter/duniter-polkadot-sdk that referenced this pull request Mar 25, 2024
…itytech#2064)

This ensures that upgrading a parachain code sends the same event &
digest as when using `set_code` on a standalone chain.

Close: paritytech#2049
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Mar 26, 2024
* fix max-size messages submit for test chains

* impl review suggestions
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Mar 26, 2024
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Mar 26, 2024
* Use wasm execution on millau and rialto

It's safer like this since here are some errors that aren't caught when
using native execution

* Revert "Revert "Fix max-size messages at test chains (paritytech#2064)" (paritytech#2077)"

This reverts commit 8c8adaf.

* Adjustments
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Mar 27, 2024
* fix max-size messages submit for test chains

* impl review suggestions
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Mar 27, 2024
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Mar 27, 2024
* Use wasm execution on millau and rialto

It's safer like this since here are some errors that aren't caught when
using native execution

* Revert "Revert "Fix max-size messages at test chains (paritytech#2064)" (paritytech#2077)"

This reverts commit be915cb.

* Adjustments
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
* fix max-size messages submit for test chains

* impl review suggestions
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
* Use wasm execution on millau and rialto

It's safer like this since here are some errors that aren't caught when
using native execution

* Revert "Revert "Fix max-size messages at test chains (paritytech#2064)" (paritytech#2077)"

This reverts commit 62f749e.

* Adjustments
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
* fix max-size messages submit for test chains

* impl review suggestions
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
* Use wasm execution on millau and rialto

It's safer like this since here are some errors that aren't caught when
using native execution

* Revert "Revert "Fix max-size messages at test chains (paritytech#2064)" (paritytech#2077)"

This reverts commit 62f749e.

* Adjustments
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
* fix max-size messages submit for test chains

* impl review suggestions
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
* Use wasm execution on millau and rialto

It's safer like this since here are some errors that aren't caught when
using native execution

* Revert "Revert "Fix max-size messages at test chains (paritytech#2064)" (paritytech#2077)"

This reverts commit 62f749e.

* Adjustments
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
* fix max-size messages submit for test chains

* impl review suggestions
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 8, 2024
* Use wasm execution on millau and rialto

It's safer like this since here are some errors that aren't caught when
using native execution

* Revert "Revert "Fix max-size messages at test chains (paritytech#2064)" (paritytech#2077)"

This reverts commit 62f749e.

* Adjustments
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
* fix max-size messages submit for test chains

* impl review suggestions
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
* Use wasm execution on millau and rialto

It's safer like this since here are some errors that aren't caught when
using native execution

* Revert "Revert "Fix max-size messages at test chains (paritytech#2064)" (paritytech#2077)"

This reverts commit 62f749e.

* Adjustments
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
* fix max-size messages submit for test chains

* impl review suggestions
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
* Use wasm execution on millau and rialto

It's safer like this since here are some errors that aren't caught when
using native execution

* Revert "Revert "Fix max-size messages at test chains (paritytech#2064)" (paritytech#2077)"

This reverts commit 62f749e.

* Adjustments
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
* fix max-size messages submit for test chains

* impl review suggestions
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
* Use wasm execution on millau and rialto

It's safer like this since here are some errors that aren't caught when
using native execution

* Revert "Revert "Fix max-size messages at test chains (paritytech#2064)" (paritytech#2077)"

This reverts commit 62f749e.

* Adjustments
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
* fix max-size messages submit for test chains

* impl review suggestions
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
* Use wasm execution on millau and rialto

It's safer like this since here are some errors that aren't caught when
using native execution

* Revert "Revert "Fix max-size messages at test chains (paritytech#2064)" (paritytech#2077)"

This reverts commit 62f749e.

* Adjustments
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
* fix max-size messages submit for test chains

* impl review suggestions
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
* Use wasm execution on millau and rialto

It's safer like this since here are some errors that aren't caught when
using native execution

* Revert "Revert "Fix max-size messages at test chains (paritytech#2064)" (paritytech#2077)"

This reverts commit 62f749e.

* Adjustments
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
* fix max-size messages submit for test chains

* impl review suggestions
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 9, 2024
* Use wasm execution on millau and rialto

It's safer like this since here are some errors that aren't caught when
using native execution

* Revert "Revert "Fix max-size messages at test chains (paritytech#2064)" (paritytech#2077)"

This reverts commit 62f749e.

* Adjustments
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
* fix max-size messages submit for test chains

* impl review suggestions
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
* Use wasm execution on millau and rialto

It's safer like this since here are some errors that aren't caught when
using native execution

* Revert "Revert "Fix max-size messages at test chains (paritytech#2064)" (paritytech#2077)"

This reverts commit 62f749e.

* Adjustments
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
* fix max-size messages submit for test chains

* impl review suggestions
serban300 pushed a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
serban300 added a commit to serban300/polkadot-sdk that referenced this pull request Apr 10, 2024
* Use wasm execution on millau and rialto

It's safer like this since here are some errors that aren't caught when
using native execution

* Revert "Revert "Fix max-size messages at test chains (paritytech#2064)" (paritytech#2077)"

This reverts commit 62f749e.

* Adjustments
bkchr pushed a commit that referenced this pull request Apr 10, 2024
* fix max-size messages submit for test chains

* impl review suggestions
bkchr pushed a commit that referenced this pull request Apr 10, 2024
bkchr pushed a commit that referenced this pull request Apr 10, 2024
* Use wasm execution on millau and rialto

It's safer like this since here are some errors that aren't caught when
using native execution

* Revert "Revert "Fix max-size messages at test chains (#2064)" (#2077)"

This reverts commit 62f749e.

* Adjustments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T1-FRAME This PR/Issue is related to core FRAME, the framework.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

parachain-system runtime upgrade did not emit CodeUpdated event and digest log
4 participants