polkadot: parachains: Fix v9 host configuration migration #2103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We shouldn't override with their default fields that have been added in the previous version(v8), because we are going to lose whatever values have been set. Note, v8 & v9 seems to have landed at the same time on Rococo, probably they will land at the same on westend and other chains, so functionally doesn't make much difference, but let's have this fixed for people that copy-paste :D, like me. Signed-off-by: Alexandru Gheorghe <[email protected]>
alexggh
added
A1-insubstantial
alindima
approved these changes
Oct 31, 2023
|
my bad, copy-paste mistake 😬 |
mrcnski
approved these changes
Oct 31, 2023
Signed-off-by: Alexandru Gheorghe <[email protected]>
ordian
approved these changes
Oct 31, 2023
ggwpez
approved these changes
Oct 31, 2023
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Mar 26, 2024
* Use wasm execution on millau and rialto It's safer like this since here are some errors that aren't caught when using native execution * Revert "Revert "Fix max-size messages at test chains (paritytech#2064)" (paritytech#2077)" This reverts commit 8c8adaf. * Adjustments
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Mar 27, 2024
* Use wasm execution on millau and rialto It's safer like this since here are some errors that aren't caught when using native execution * Revert "Revert "Fix max-size messages at test chains (paritytech#2064)" (paritytech#2077)" This reverts commit be915cb. * Adjustments
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
* Use wasm execution on millau and rialto It's safer like this since here are some errors that aren't caught when using native execution * Revert "Revert "Fix max-size messages at test chains (paritytech#2064)" (paritytech#2077)" This reverts commit 62f749e. * Adjustments
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
* Use wasm execution on millau and rialto It's safer like this since here are some errors that aren't caught when using native execution * Revert "Revert "Fix max-size messages at test chains (paritytech#2064)" (paritytech#2077)" This reverts commit 62f749e. * Adjustments
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
* Use wasm execution on millau and rialto It's safer like this since here are some errors that aren't caught when using native execution * Revert "Revert "Fix max-size messages at test chains (paritytech#2064)" (paritytech#2077)" This reverts commit 62f749e. * Adjustments
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
* Use wasm execution on millau and rialto It's safer like this since here are some errors that aren't caught when using native execution * Revert "Revert "Fix max-size messages at test chains (paritytech#2064)" (paritytech#2077)" This reverts commit 62f749e. * Adjustments
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
* Use wasm execution on millau and rialto It's safer like this since here are some errors that aren't caught when using native execution * Revert "Revert "Fix max-size messages at test chains (paritytech#2064)" (paritytech#2077)" This reverts commit 62f749e. * Adjustments
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
* Use wasm execution on millau and rialto It's safer like this since here are some errors that aren't caught when using native execution * Revert "Revert "Fix max-size messages at test chains (paritytech#2064)" (paritytech#2077)" This reverts commit 62f749e. * Adjustments
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
* Use wasm execution on millau and rialto It's safer like this since here are some errors that aren't caught when using native execution * Revert "Revert "Fix max-size messages at test chains (paritytech#2064)" (paritytech#2077)" This reverts commit 62f749e. * Adjustments
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
* Use wasm execution on millau and rialto It's safer like this since here are some errors that aren't caught when using native execution * Revert "Revert "Fix max-size messages at test chains (paritytech#2064)" (paritytech#2077)" This reverts commit 62f749e. * Adjustments
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
* Use wasm execution on millau and rialto It's safer like this since here are some errors that aren't caught when using native execution * Revert "Revert "Fix max-size messages at test chains (paritytech#2064)" (paritytech#2077)" This reverts commit 62f749e. * Adjustments
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
* Use wasm execution on millau and rialto It's safer like this since here are some errors that aren't caught when using native execution * Revert "Revert "Fix max-size messages at test chains (paritytech#2064)" (paritytech#2077)" This reverts commit 62f749e. * Adjustments
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
* Use wasm execution on millau and rialto It's safer like this since here are some errors that aren't caught when using native execution * Revert "Revert "Fix max-size messages at test chains (paritytech#2064)" (paritytech#2077)" This reverts commit 62f749e. * Adjustments
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 10, 2024
* Use wasm execution on millau and rialto It's safer like this since here are some errors that aren't caught when using native execution * Revert "Revert "Fix max-size messages at test chains (paritytech#2064)" (paritytech#2077)" This reverts commit 62f749e. * Adjustments
serban300
added a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 10, 2024
* Use wasm execution on millau and rialto It's safer like this since here are some errors that aren't caught when using native execution * Revert "Revert "Fix max-size messages at test chains (paritytech#2064)" (paritytech#2077)" This reverts commit 62f749e. * Adjustments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't override with their default fields that have been added in the
previous version(v8), because we are going to lose whatever values have been set.
Note, v8 & v9 seems to have landed at the same time on Rococo, probably they will
land at the same time on westend and other chains, so functionally doesn't make
much difference, but let's have this fixed for people that copy-paste :D, like me.