-
Notifications
You must be signed in to change notification settings - Fork 707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ValidationError
#1958
Refactor ValidationError
#1958
Conversation
Woah, awesome! I totally missed this. Is it ready for review @eagr ? |
Not ready yet. I plan to continue on this after the artifact pr. :) |
Hey @eagr, quick update from me! Getting #1685 merged is my highest priority right now, and as part of that PR I need to do a somewhat big error refactor. There hopefully won't be too many conflicts with this work, but it's pretty substantial, so consider this a heads-up! I apologize for the delays and any inconvenience, but after that PR goes in I'll be much more free to focus on other things, like reviewing the artifacts PR to unblock this one. :) |
Isn't having merge conflicts the norm? :) Totally understand. And usually I wouldn't fixate on something. I'll just move on to the next thing, like green threads do, so no worries man. |
The CI pipeline was cancelled due to failure one of the required jobs. |
Gonna redo this based on master as it's probably faster and easier to get right than trying to solve the conflicts. :) @mrcnski |
closes #660
closes #661
closes #733