You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
eskimor opened this issue
Jan 22, 2023
· 0 comments
· Fixed by #2406
Labels
C1-mentorA task where a mentor is available. Please indicate in the issue who the mentor could be.D0-easyCan be fixed primarily by duplicating and adapting code by an intermediate coder.
Since we have prechecking enabled, we no longer want to treat preparation error as if the candidate was invalid. Hence PrepareError should not be a variant of the InvalidCandidate enum, but instead be consolidated with `ValidationError::InternalError.
In particular InternalError represents spurious errors, while PrepareError represents deterministic errors. This differentiation is still useful, so instead of making those two errors one, I would suggest to only move PrepareError to the ValidationError enum, but reconsider the naming as both InternalError and PrepareError are prepare errors.
The text was updated successfully, but these errors were encountered:
* Revert "Pin Rust Nightly to 2020-12-17 (#652)"
This reverts commit e54e6f7.
* fix clippy
* clippy again
* more clippy in test code
* and new cargo fmt
* another try
C1-mentorA task where a mentor is available. Please indicate in the issue who the mentor could be.D0-easyCan be fixed primarily by duplicating and adapting code by an intermediate coder.
Since we have prechecking enabled, we no longer want to treat preparation error as if the candidate was invalid. Hence
PrepareError
should not be a variant of theInvalidCandidate
enum, but instead be consolidated with `ValidationError::InternalError.In particular
InternalError
represents spurious errors, whilePrepareError
represents deterministic errors. This differentiation is still useful, so instead of making those two errors one, I would suggest to only movePrepareError
to theValidationError
enum, but reconsider the naming as bothInternalError
andPrepareError
are prepare errors.The text was updated successfully, but these errors were encountered: