-
Notifications
You must be signed in to change notification settings - Fork 680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preparation errors should no longer be a InvalidCandidate
variant
#733
Comments
the-right-joyce
added
C1-mentor
A task where a mentor is available. Please indicate in the issue who the mentor could be.
and removed
J7-mentor
labels
Aug 25, 2023
the-right-joyce
added
the
D0-easy
Can be fixed primarily by duplicating and adapting code by an intermediate coder.
label
Oct 18, 2023
claravanstaden
added a commit
to Snowfork/polkadot-sdk
that referenced
this issue
Dec 8, 2023
* Updates for lodestar v1.2.1 * Updates tests. * Updates tests. * Fix last test * Cleanup tests and add github repo token to protoc job * Update benchmark data. * Fix benchmark tests. * Fix spacing * Updates lockfile * Adds newlines. * Changes ForkVersions to a struct * Fix whitespace.
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this issue
Apr 8, 2024
* Revert "Pin Rust Nightly to 2020-12-17 (paritytech#652)" This reverts commit e54e6f7. * fix clippy * clippy again * more clippy in test code * and new cargo fmt * another try
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this issue
Apr 8, 2024
* Revert "Pin Rust Nightly to 2020-12-17 (paritytech#652)" This reverts commit e54e6f7. * fix clippy * clippy again * more clippy in test code * and new cargo fmt * another try
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this issue
Apr 8, 2024
* Revert "Pin Rust Nightly to 2020-12-17 (paritytech#652)" This reverts commit e54e6f7. * fix clippy * clippy again * more clippy in test code * and new cargo fmt * another try
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this issue
Apr 8, 2024
* Revert "Pin Rust Nightly to 2020-12-17 (paritytech#652)" This reverts commit e54e6f7. * fix clippy * clippy again * more clippy in test code * and new cargo fmt * another try
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this issue
Apr 9, 2024
* Revert "Pin Rust Nightly to 2020-12-17 (paritytech#652)" This reverts commit e54e6f7. * fix clippy * clippy again * more clippy in test code * and new cargo fmt * another try
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this issue
Apr 9, 2024
* Revert "Pin Rust Nightly to 2020-12-17 (paritytech#652)" This reverts commit e54e6f7. * fix clippy * clippy again * more clippy in test code * and new cargo fmt * another try
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this issue
Apr 9, 2024
* Revert "Pin Rust Nightly to 2020-12-17 (paritytech#652)" This reverts commit e54e6f7. * fix clippy * clippy again * more clippy in test code * and new cargo fmt * another try
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this issue
Apr 9, 2024
* Revert "Pin Rust Nightly to 2020-12-17 (paritytech#652)" This reverts commit e54e6f7. * fix clippy * clippy again * more clippy in test code * and new cargo fmt * another try
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this issue
Apr 9, 2024
* Revert "Pin Rust Nightly to 2020-12-17 (paritytech#652)" This reverts commit e54e6f7. * fix clippy * clippy again * more clippy in test code * and new cargo fmt * another try
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this issue
Apr 9, 2024
* Revert "Pin Rust Nightly to 2020-12-17 (paritytech#652)" This reverts commit e54e6f7. * fix clippy * clippy again * more clippy in test code * and new cargo fmt * another try
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this issue
Apr 10, 2024
* Revert "Pin Rust Nightly to 2020-12-17 (paritytech#652)" This reverts commit e54e6f7. * fix clippy * clippy again * more clippy in test code * and new cargo fmt * another try
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this issue
Apr 10, 2024
* Revert "Pin Rust Nightly to 2020-12-17 (paritytech#652)" This reverts commit e54e6f7. * fix clippy * clippy again * more clippy in test code * and new cargo fmt * another try
bkchr
pushed a commit
that referenced
this issue
Apr 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since we have prechecking enabled, we no longer want to treat preparation error as if the candidate was invalid. Hence
PrepareError
should not be a variant of theInvalidCandidate
enum, but instead be consolidated with `ValidationError::InternalError.In particular
InternalError
represents spurious errors, whilePrepareError
represents deterministic errors. This differentiation is still useful, so instead of making those two errors one, I would suggest to only movePrepareError
to theValidationError
enum, but reconsider the naming as bothInternalError
andPrepareError
are prepare errors.The text was updated successfully, but these errors were encountered: