Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

substrate: peer_store: log warn on disconnecting because of reputation #1299

Merged
merged 5 commits into from
Aug 31, 2023
Merged

substrate: peer_store: log warn on disconnecting because of reputation #1299

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
097b268
substrate: peer_store: log error on disconnecting because of reputation
alexggh Aug 30, 2023
6bfb9fc
Move from error to warn
alexggh Aug 30, 2023
f7316b7
Merge branch 'master' into alexaggh/threshold_log_error
alexggh Aug 30, 2023
a86c391
Merge branch 'master' into alexaggh/threshold_log_error
alexggh Aug 30, 2023
c7560e6
Merge branch 'master' into alexaggh/threshold_log_error
alexggh Aug 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion substrate/client/network/src/peer_store.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,7 +222,7 @@ impl PeerStoreInner {
if peer_info.reputation < BANNED_THRESHOLD {
self.protocols.iter().for_each(|handle| handle.disconnect_peer(peer_id));

log::trace!(
log::error!(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer warning instead of error.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree! Done.

target: LOG_TARGET,
"Report {}: {:+} to {}. Reason: {}. Banned, disconnecting.",
peer_id,
Expand Down