substrate: peer_store: log warn on disconnecting because of reputation #1299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Disconnecting and banning a peer because of negative reputation is usually an indicative of one of two things: 1. We've got a bug that forces disconnects. 2. We've got malicious peers that try to attack us. We both cases I don't think we should hide this behind a trace log and we should log errors, so that things are easy to notice and debug/mitigated. Signed-off-by: Alexandru Gheorghe <[email protected]>
alexggh
added
A1-insubstantial
altonen
approved these changes
Aug 30, 2023
lexnv
approved these changes
Aug 30, 2023
dmitry-markin
approved these changes
Aug 30, 2023
acatangiu
approved these changes
Aug 30, 2023
sandreim
approved these changes
Aug 30, 2023
| @@ -222,7 +222,7 @@ impl PeerStoreInner { | |||
| if peer_info.reputation < BANNED_THRESHOLD { | |||
| self.protocols.iter().for_each(|handle| handle.disconnect_peer(peer_id)); | |||
|
|
|||
| log::trace!( | |||
| log::error!( | |||
There was a problem hiding this comment.
I would prefer warning instead of error.
Signed-off-by: Alexandru Gheorghe <[email protected]>
alexggh
changed the title
Daanvdplas
pushed a commit
that referenced
this pull request
Sep 11, 2023
#1299) * substrate: peer_store: log error on disconnecting because of reputation Disconnecting and banning a peer because of negative reputation is usually an indicative of one of two things: 1. We've got a bug that forces disconnects. 2. We've got malicious peers that try to attack us. We both cases I don't think we should hide this behind a trace log and we should log errors, so that things are easy to notice and debug/mitigated. Signed-off-by: Alexandru Gheorghe <[email protected]> * Move from error to warn Signed-off-by: Alexandru Gheorghe <[email protected]> --------- Signed-off-by: Alexandru Gheorghe <[email protected]>
bgallois
pushed a commit
to duniter/duniter-polkadot-sdk
that referenced
this pull request
Mar 25, 2024
paritytech#1299) * substrate: peer_store: log error on disconnecting because of reputation Disconnecting and banning a peer because of negative reputation is usually an indicative of one of two things: 1. We've got a bug that forces disconnects. 2. We've got malicious peers that try to attack us. We both cases I don't think we should hide this behind a trace log and we should log errors, so that things are easy to notice and debug/mitigated. Signed-off-by: Alexandru Gheorghe <[email protected]> * Move from error to warn Signed-off-by: Alexandru Gheorghe <[email protected]> --------- Signed-off-by: Alexandru Gheorghe <[email protected]>
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
…h#1299) * use raw balance value if tokenDecimals property is missing * fmt
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
…h#1299) * use raw balance value if tokenDecimals property is missing * fmt
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
…h#1299) * use raw balance value if tokenDecimals property is missing * fmt
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 8, 2024
…h#1299) * use raw balance value if tokenDecimals property is missing * fmt
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
…h#1299) * use raw balance value if tokenDecimals property is missing * fmt
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
…h#1299) * use raw balance value if tokenDecimals property is missing * fmt
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
…h#1299) * use raw balance value if tokenDecimals property is missing * fmt
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
…h#1299) * use raw balance value if tokenDecimals property is missing * fmt
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
…h#1299) * use raw balance value if tokenDecimals property is missing * fmt
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 9, 2024
…h#1299) * use raw balance value if tokenDecimals property is missing * fmt
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 10, 2024
…h#1299) * use raw balance value if tokenDecimals property is missing * fmt
serban300
pushed a commit
to serban300/polkadot-sdk
that referenced
this pull request
Apr 10, 2024
…h#1299) * use raw balance value if tokenDecimals property is missing * fmt
bkchr
pushed a commit
that referenced
this pull request
Apr 10, 2024
* use raw balance value if tokenDecimals property is missing * fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disconnecting and banning a peer because of negative reputation is usually an indicative of one of two things:
In both cases I don't think we should hide this behind a trace log and we should log errors, so that things are easy to notice and debug/mitigated.