This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
[Backport] [Revert] Use XCM V3 for initiate_teleport weight calc #2102 (#2394) source #2403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Revert "[Enhancement] Use XCM V3 for initiate_teleport weight calc (#2102)" This reverts commit 8230ec4. * updating weight format * We expect to pay 1bn+ for a teleport at the current weights. * The test isn't needed and hardcoded scale is hand to maintain. * remove unused imports --------- Co-authored-by: Giles Cope <[email protected]>
EgorPopelyaev
added
B0-silent
EgorPopelyaev
requested review from
ruseinov,
gilescope,
jsidorenko,
muharem,
tonyalaribe,
bkontur and
joepetrowski
ruseinov
approved these changes
Mar 29, 2023
muharem
reviewed
Mar 29, 2023
| @@ -149,7 +138,10 @@ impl<Call> XcmWeightInfo<Call> for StatemineXcmWeight<Call> { | |||
| _dest: &MultiLocation, | |||
| _xcm: &Xcm<()>, | |||
| ) -> Weight { | |||
| assets.weigh_multi_assets(XcmFungibleWeight::<Runtime>::initiate_teleport()) | |||
| // Hardcoded till the XCM pallet is fixed | |||
muharem
approved these changes
Mar 29, 2023
|
bot merge |
|
Waiting for commit status. |
gilescope
approved these changes
Mar 29, 2023
EgorPopelyaev
deleted the
ep-backport-revert-2102-xcm-v3-for-teleport-source
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR backports #2394 from the runtimes release branch to the source release branch