Skip to content
This repository has been archived by the owner on Nov 15, 2023. It is now read-only.

[Revert] Use XCM V3 for initiate_teleport weight calc #2102 #2394

Merged

Conversation

EgorPopelyaev
Copy link
Contributor

@EgorPopelyaev EgorPopelyaev commented Mar 28, 2023

This PR reverts changes made in #2102 because of #2392

@EgorPopelyaev EgorPopelyaev added B0-silent Changes should not be mentioned in any release notes A0-please_review Pull request needs code review. C1-low PR touches the given topic and has a low impact on builders. labels Mar 28, 2023
Copy link
Contributor

@muharem muharem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EgorPopelyaev why we wanna revert?

@joepetrowski
Copy link
Contributor

@EgorPopelyaev why we wanna revert?

Because the message constructed on the Polkadot side uses All, which makes this fee equal to max_assets. It should be reverted until the Polkadot message uses the Counted variant for accurate weight.

@gilescope gilescope merged commit e98ed6e into release-parachains-v9400 Mar 29, 2023
@gilescope gilescope deleted the ep-revert-2102-xcm-v3-for-teleport branch March 29, 2023 15:34
EgorPopelyaev added a commit that referenced this pull request Mar 29, 2023
* Revert "[Enhancement] Use XCM V3 for initiate_teleport weight calc (#2102)"

This reverts commit 8230ec4.

* updating weight format

* We expect to pay 1bn+ for a teleport at the current weights.

* The test isn't needed and hardcoded scale is hand to maintain.

* remove unused imports

---------

Co-authored-by: Giles Cope <[email protected]>
EgorPopelyaev added a commit that referenced this pull request Mar 29, 2023
* Revert "[Enhancement] Use XCM V3 for initiate_teleport weight calc (#2102)"

This reverts commit 8230ec4.

* updating weight format

* We expect to pay 1bn+ for a teleport at the current weights.

* The test isn't needed and hardcoded scale is hand to maintain.

* remove unused imports

---------

Co-authored-by: Giles Cope <[email protected]>
EgorPopelyaev added a commit that referenced this pull request Mar 30, 2023
…2402)

* Revert "[Enhancement] Use XCM V3 for initiate_teleport weight calc (#2102)"

This reverts commit 8230ec4.

* updating weight format

* We expect to pay 1bn+ for a teleport at the current weights.

* The test isn't needed and hardcoded scale is hand to maintain.

* remove unused imports

---------

Co-authored-by: Giles Cope <[email protected]>
EgorPopelyaev added a commit that referenced this pull request Mar 30, 2023
…2403)

* Revert "[Enhancement] Use XCM V3 for initiate_teleport weight calc (#2102)"

This reverts commit 8230ec4.

* updating weight format

* We expect to pay 1bn+ for a teleport at the current weights.

* The test isn't needed and hardcoded scale is hand to maintain.

* remove unused imports

---------

Co-authored-by: Giles Cope <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A0-please_review Pull request needs code review. B0-silent Changes should not be mentioned in any release notes C1-low PR touches the given topic and has a low impact on builders.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants