This repository has been archived by the owner on Nov 15, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 378
[Revert] Use XCM V3 for initiate_teleport weight calc #2102 #2394
Merged
gilescope
merged 5 commits into
release-parachains-v9400
from
ep-revert-2102-xcm-v3-for-teleport
Mar 29, 2023
Merged
[Revert] Use XCM V3 for initiate_teleport weight calc #2102 #2394
gilescope
merged 5 commits into
release-parachains-v9400
from
ep-revert-2102-xcm-v3-for-teleport
Mar 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EgorPopelyaev
added
B0-silent
Changes should not be mentioned in any release notes
A0-please_review
Pull request needs code review.
C1-low
PR touches the given topic and has a low impact on builders.
labels
Mar 28, 2023
EgorPopelyaev
requested review from
ruseinov,
gilescope,
jsidorenko,
muharem,
tonyalaribe,
bkontur and
joepetrowski
March 28, 2023 12:31
muharem
reviewed
Mar 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EgorPopelyaev why we wanna revert?
Because the message constructed on the Polkadot side uses |
bkontur
approved these changes
Mar 29, 2023
gilescope
approved these changes
Mar 29, 2023
EgorPopelyaev
added a commit
that referenced
this pull request
Mar 29, 2023
* Revert "[Enhancement] Use XCM V3 for initiate_teleport weight calc (#2102)" This reverts commit 8230ec4. * updating weight format * We expect to pay 1bn+ for a teleport at the current weights. * The test isn't needed and hardcoded scale is hand to maintain. * remove unused imports --------- Co-authored-by: Giles Cope <[email protected]>
EgorPopelyaev
added a commit
that referenced
this pull request
Mar 29, 2023
* Revert "[Enhancement] Use XCM V3 for initiate_teleport weight calc (#2102)" This reverts commit 8230ec4. * updating weight format * We expect to pay 1bn+ for a teleport at the current weights. * The test isn't needed and hardcoded scale is hand to maintain. * remove unused imports --------- Co-authored-by: Giles Cope <[email protected]>
This was referenced Mar 29, 2023
Merged
EgorPopelyaev
added a commit
that referenced
this pull request
Mar 30, 2023
…2402) * Revert "[Enhancement] Use XCM V3 for initiate_teleport weight calc (#2102)" This reverts commit 8230ec4. * updating weight format * We expect to pay 1bn+ for a teleport at the current weights. * The test isn't needed and hardcoded scale is hand to maintain. * remove unused imports --------- Co-authored-by: Giles Cope <[email protected]>
EgorPopelyaev
added a commit
that referenced
this pull request
Mar 30, 2023
…2403) * Revert "[Enhancement] Use XCM V3 for initiate_teleport weight calc (#2102)" This reverts commit 8230ec4. * updating weight format * We expect to pay 1bn+ for a teleport at the current weights. * The test isn't needed and hardcoded scale is hand to maintain. * remove unused imports --------- Co-authored-by: Giles Cope <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
A0-please_review
Pull request needs code review.
B0-silent
Changes should not be mentioned in any release notes
C1-low
PR touches the given topic and has a low impact on builders.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reverts changes made in #2102 because of #2392