Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude pallet_example_* from bench-all-substrate #69

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Exclude pallet_example_* from bench-all-substrate #69

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions commands/bench/lib/bench-all-substrate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,10 @@ EXCLUDED_PALLETS=(
"pallet_offences"
# Only used for testing, does not need real weights.
"frame_benchmarking_pallet_pov"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really? We have the excluded list here in this repo? @paritytech/opstooling please fix this and move the excluded list to the repo where this is executed, aka polkadot-sdk.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea it was copied from substate repo while ago as is. Will move it to polkadot-sdk then

Copy link
Collaborator

@mordamax mordamax Apr 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkchr we're thinking to actually move all the commands to polkadot-sdk when we migrate to cmd bot as GHA. @Bullrich is on it. For now I will keep it here though, or if you think it won't wait few weeks - we can move the definition of excluded list of pallets only

"pallet_example_tasks"
"pallet_example_basic"
"pallet_example_split"
"pallet_example_kitchensink"
)

# Load all pallet names in an array.
Expand Down