Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exclude pallet_example_* from bench-all-substrate #69

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Exclude pallet_example_* from bench-all-substrate #69

merged 1 commit into from
Apr 3, 2024

Conversation

pgherveou
Copy link
Contributor

@pgherveou pgherveou commented Apr 3, 2024 •
edited
Loading

Looks like these fail with

Error: Input("No benchmarks found which match your input.")

Tested locally with

cargo run --features runtime-benchmarks --bin substrate-node -- benchmark pallet --extra -p pallet_example_split  -e="*" --steps 2 --repeat 2  --output /tmp/weights.rs

@pgherveou pgherveou requested a review from a team as a code owner April 3, 2024 05:44
@pgherveou pgherveou requested a review from ggwpez April 3, 2024 05:44
@pgherveou pgherveou force-pushed the pg/exclude-pallet_example_-from-bench-all-substrate branch from 299d35e to 04cbe1f Compare April 3, 2024 06:06
bkchr
bkchr reviewed Apr 3, 2024
View reviewed changes
commands/bench/lib/bench-all-substrate.sh
@@ -53,6 +53,10 @@ EXCLUDED_PALLETS=(
"pallet_offences"
# Only used for testing, does not need real weights.
"frame_benchmarking_pallet_pov"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really? We have the excluded list here in this repo? @paritytech/opstooling please fix this and move the excluded list to the repo where this is executed, aka polkadot-sdk.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea it was copied from substate repo while ago as is. Will move it to polkadot-sdk then

Copy link
Collaborator

@mordamax mordamax Apr 3, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bkchr we're thinking to actually move all the commands to polkadot-sdk when we migrate to cmd bot as GHA. @Bullrich is on it. For now I will keep it here though, or if you think it won't wait few weeks - we can move the definition of excluded list of pallets only

@mordamax mordamax merged commit b27aa6e into main Apr 3, 2024
1 check passed
@mordamax mordamax deleted the pg/exclude-pallet_example_-from-bench-all-substrate branch April 3, 2024 08:43
@pgherveou
Copy link
Contributor Author

@mordamax can these changes be used now on my polkadot-sdk PR, or it needs some kind of deployment before ?

@mordamax mordamax mentioned this pull request Apr 3, 2024
Closed
@mordamax
Copy link
Collaborator

mordamax commented Apr 3, 2024

@mordamax can these changes be used now on my polkadot-sdk PR, or it needs some kind of deployment before ?

yes, as soon as this is merged

@Bullrich Bullrich mentioned this pull request Apr 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkchr bkchr bkchr left review comments

@mordamax mordamax mordamax approved these changes

@ggwpez ggwpez Awaiting requested review from ggwpez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pgherveou @mordamax @bkchr