Added Verse Ref View Extension

[tjcouch-sil]

Simple little web view that displays the current verse reference. Mainly to help Mac users test Verse Reference stuff especially later when we get scroll groups going.

---

This change is 

[irahopkinson]

This was quick - must have had it already in the wings.

Reviewed 36 of 36 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @tjcouch-sil)

---

src/verse-ref-view/.eslintrc.js line 10 at r1 (raw file):

    // Make sure this is last so it gets the chance to override other configs.
    // See https://github.com/prettier/eslint-config-prettier and https://github.com/prettier/eslint-plugin-prettier
    'plugin:prettier/recommended',

BTW: Strictly you don't need this as it's included in erb. You only need it if erb isn't the last item extended (it's currently first and last).

---

src/verse-ref-view/contributions/menus.json line 11 at r1 (raw file):

        "group": "platform.projectResources",
        "order": -85,
        "command": "verseRefView.open"

This menu item is not visible for me so I couldn't see all your good work.

---

src/verse-ref-view/src/verse-ref.web-view.tsx line 38 at r1 (raw file):

const defaultScrRef: ScriptureReference = { bookNum: 1, chapterNum: 1, verseNum: 1 };

global.webViewComponent = function VerseImageGenerator({

This function seems incorrectly named. Copy and paste error?

Code quote:

VerseImageGenerator

---

src/verse-ref-view/src/verse-ref.web-view.tsx line 78 at r1 (raw file):

  // Get the current verse from the project
  const [verse] = useProjectData('ParatextStandard', projectId).VerseUSFM(verseRef, '');

BTW: I'm guessing this won't currently work on macOS but behaves nicely when it doesn't.

[tjcouch-sil]

Reviewable status: 35 of 36 files reviewed, 2 unresolved discussions (waiting on @irahopkinson)

---

src/verse-ref-view/.eslintrc.js line 10 at r1 (raw file):

Previously, irahopkinson (Ira Hopkinson) wrote…

BTW: Strictly you don't need this as it's included in erb. You only need it if erb isn't the last item extended (it's currently first and last).

Ah interesting, this is here on the paranext-core one to overwrite storybook's rules paranext/paranext-core@d72f363 I didn't realize that when making this template eslintrc. I'd say let's just leave it at this point. Or if someone wants to make a template change, that's totally fine.

---

src/verse-ref-view/contributions/menus.json line 11 at r1 (raw file):

Previously, irahopkinson (Ira Hopkinson) wrote…

This menu item is not visible for me so I couldn't see all your good work.

Did you have fix-web-view-menus checked out on paranext-core? None of this works without it because of the bug I fixed in that (and the localized string added).

---

src/verse-ref-view/src/verse-ref.web-view.tsx line 38 at r1 (raw file):

Previously, irahopkinson (Ira Hopkinson) wrote…

This function seems incorrectly named. Copy and paste error?

Good call. Fixed

---

src/verse-ref-view/src/verse-ref.web-view.tsx line 78 at r1 (raw file):

Previously, irahopkinson (Ira Hopkinson) wrote…

BTW: I'm guessing this won't currently work on macOS but behaves nicely when it doesn't.

Right haha it probably doesn't show anything on mac. I just figured might as well throw it in so windows (and hopefully one day mac) users see something interesting in the web view.

[irahopkinson]

BTW: if it matters the package-lock.json file isn't up-to-date.

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @tjcouch-sil)

---

src/verse-ref-view/contributions/menus.json line 11 at r1 (raw file):

Previously, tjcouch-sil (TJ Couch) wrote…

Did you have fix-web-view-menus checked out on paranext-core? None of this works without it because of the bug I fixed in that (and the localized string added).

Yes, I also tried that yesterday figuring it was related. Haha, I think I forgot to checkout this branch yesterday since I didn't notice that the package-lock.json file wasn't up-to-date yesterday. It's working now 😁 .

[tjcouch-sil]

Oops. I think maybe we can just wait til next PR if that's ok. Thanks for the review!

Reviewable status: complete! all files reviewed, all discussions resolved