Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update @sillsdev/scripture #7

Merged
merged 4 commits into from
Jul 19, 2024
Merged

update @sillsdev/scripture #7

merged 4 commits into from
Jul 19, 2024

Conversation

irahopkinson
Copy link
Contributor

@irahopkinson irahopkinson commented Jul 19, 2024

  • fix .NET deserialization

This change is Reviewable

irahopkinson and others added 4 commits July 18, 2024 17:03
- fix .NET deserialization
01213e7 update `@sillsdev/scripture` (#74)
652c777 feat: added some fields to `manifest.json` and moved URL-related fields (#73)
8076b16 fix: changed elevatedPrivileges to an array
ccbf06c refactor: adjusted structure for fields in manifest.json
4df6936 feat: added 'moreInfoUrl' and 'supportUrl' to manifest

git-subtree-dir: src/verse-ref-view
git-subtree-split: 01213e7e2372ab91e5ac17299cc531ec586048ae
Copy link
Member

@tjcouch-sil tjcouch-sil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: thanks!

Reviewed 6 of 6 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @irahopkinson)

@irahopkinson irahopkinson merged commit 57d708a into main Jul 19, 2024
1 check was pending
@irahopkinson irahopkinson deleted the update-scripture branch July 19, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants